Add Policy.JSON_REFORM_SUFFIXES set and related test #1503
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request simplifies the
col_label
names in thecurrent_law_policy.json
file.The simplifications include making them all lower case, eliminating spaces, and shortening long labels.
The purpose of this pull request is to prepare for the addition of an optional capability that will simplify the specification of JSON reform files when the reform includes changes in policy parameters that are indexed (by
MARS
,EIC
oridedtype
). That optional capability is primarily intended for the use of TaxBrain --- see TaxBrain issue 596 --- but may also be used in hand-prepared JSON reform files. This new capability will be added in another pull request.I have looked at the TaxBrain code in the
webapp/apps/taxbrain
directory and have not found any code that would be affected by the changes incol_label
values incurrent_law_policy.json
. The TaxBrain code does check for the EIC-indexedcol_label
names, but those are unchanged in this pull request. So, as best as I can tell, the changes in this pull request do not change the Tax-Calculator public API.@MattHJensen @feenberg @Amy-Xu @andersonfrailey @hdoupe @GoFroggyRun @codykallen
@talumbau @PeterDSteinberg @brittainhard