Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce DefaultExperiment tag in OspSystemStructure.xml #404

Open
eidekrist opened this issue Oct 3, 2019 · 2 comments
Open

Introduce DefaultExperiment tag in OspSystemStructure.xml #404

eidekrist opened this issue Oct 3, 2019 · 2 comments
Labels
discussion needed Let's have a discussion about this enhancement New feature or request

Comments

@eidekrist
Copy link
Member

Let's continue the discussion from #333, where @markaren proposed to introduce a DefaultExperiment tag in OspSystemStructure.xml:

My comment about putting the (optional) runtime specific entries into a DefaultExperiment tag were never addressed. I'd really like to see something like:

<DefaultExperiment startTime="0.0">
      <Algorithm name="fixedStep" stepSize="1e-4"></Algorithm>
</DefaultExperiment>

Which can be completely ommited btw, rather than:

<StartTime>0.0</StartTime>
<BaseStepSize>1e-4</BaseStepSize>
<Algorithm>fixedStep</Algorithm>

However, the parameters to the Algorithm would be algorithm specific, dunno how that should best be handled. Probably some annotations stuff. Then basically you can have the exact same layout in SSP.

@eidekrist eidekrist added enhancement New feature or request discussion needed Let's have a discussion about this labels Oct 3, 2019
@markaren
Copy link
Contributor

markaren commented Oct 3, 2019

Thanks.

It follows that I would want to make a similar change to our SSP implementation. The standard itself suggests that algorithm specific stuff like stepSize should/could be listed as annotations within SSPs DefaultExperiment tag. I suggest we do just that.

Edit: See PR #426

@markaren
Copy link
Contributor

markaren commented Oct 22, 2019

I propose to use this XML:

<DefaultExperiment startTime="0.0">
    <osp:Algorithm>
        <osp:FixedStepAlgorithm baseStepSize="0.01"/>
    </osp:Algorithm>
</DefaultExperiment >

This is quite similar to the SPP version, but without the annotation tags.

Looks better than

<StartTime>0.0</StartTime>
<BaseStepSize>1e-4</BaseStepSize>
<Algorithm>fixedStep</Algorithm>

no?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion needed Let's have a discussion about this enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants