Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/logconfig xsd #555

Merged
merged 5 commits into from
Apr 17, 2020
Merged

Feature/logconfig xsd #555

merged 5 commits into from
Apr 17, 2020

Conversation

markaren
Copy link
Contributor

@markaren markaren commented Apr 6, 2020 •
edited
Loading

Add XSD for logconfig and add option for generating non-timestamped csv files.

ljamt
ljamt reviewed Apr 15, 2020
View reviewed changes
test/data/LogConfig.xsd Outdated Show resolved Hide resolved
@ljamt
Copy link
Member

ljamt commented Apr 15, 2020

any good reason why the file writer was set to append mode prior?

First thing that came to mind was the on/off toggle support #509. Looking closer at it, I don't think it matters.

@markaren
Copy link
Contributor Author

I don't think it matters.

Should I perhaps add an if else just to be safe?

@markaren
Copy link
Contributor Author

markaren commented Apr 15, 2020 •
edited
Loading

#509 closes and reopens the stream, so I think it needs to append.

I should probably wipe the file contents when staticFileNames=true to make this work, and keep append mode.

@ljamt
Copy link
Member

ljamt commented Apr 15, 2020

#509 closes and reopens the stream, so I think it needs to append.

I should probably wipe the file contents when staticFileNames=true to make this work, and keep append mode.

Yes, I was wrong. It needs append mode.

@markaren
Copy link
Contributor Author

PR is now backwards compatible and compatiable with dynamic logging also when timeStampedFileNames=false.

ljamt
ljamt approved these changes Apr 17, 2020
View reviewed changes
Copy link
Member

@ljamt ljamt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

hplatou
hplatou approved these changes Apr 17, 2020
View reviewed changes
Copy link
Contributor

@hplatou hplatou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@markaren markaren merged commit 0eac8ce into master Apr 17, 2020
@markaren markaren deleted the feature/logconfig-xsd branch April 17, 2020 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hplatou hplatou hplatou approved these changes

@ljamt ljamt ljamt approved these changes

@kyllingstad kyllingstad Awaiting requested review from kyllingstad

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@markaren @ljamt @hplatou