You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Always update at each time step when a manipulator is present. (Simplest, but feels a bit crude.)
Add a parameter to simulator::set_xxx_manipulator() that allows client code to specify whether the value should be updated at each time step or only when there are incoming values. (Does the client code always know which to choose, though?)
Add some machinery in both algorithm and simulator implementations whereby an algorithm can tell a simulator whether each of its variables is connected. (Overengineered?)
This is starting to feel like a design choice. Until we hash out a master plan for the intended usage of these manipulator functions - i.e. how often will they be called, how good of an idea is statefulness etc., and as long as there are no current stateful manipulator function implementations, I'm OK with tackling this in a future issue.
The manipulator functions don't get the current time, nor the step size, at the moment, so more changes are needed to support that case.
Another input to this debate is the cse::manipulator class, which gets notified each time a step commences. This could also be taken advantage of when it comes to time dependent manipulations.
This is starting to feel like a design choice. Until we hash out a master plan for the intended usage of these manipulator functions - i.e. how often will they be called, how good of an idea is statefulness etc., and as long as there are no current stateful manipulator function implementations, I'm OK with tackling this in a future issue.
Another input to this debate is the
cse::manipulator
class, which gets notified each time a step commences. This could also be taken advantage of when it comes to time dependent manipulations.Originally posted by @eidekrist in #189 (comment)
The text was updated successfully, but these errors were encountered: