From bcbf1bb0f6a86d5b8da235b3ef92c92a5d3d6d8b Mon Sep 17 00:00:00 2001 From: shubhamchasing Date: Thu, 3 Oct 2024 23:09:42 +0530 Subject: [PATCH 01/10] fix: resolve a11y warnings for label-has-associated-control rule (#4126) --- .../add-contributors-header.tsx | 3 +- components/atoms/Search/search.tsx | 4 +- components/atoms/Select/single-select.tsx | 3 + .../UserSettingsPage/user-settings-page.tsx | 79 +++++++++++++++++-- components/shared/AppSidebar/AppSidebar.tsx | 3 +- components/shared/DayRangePicker.tsx | 3 +- components/shared/LimitPicker.tsx | 3 +- 7 files changed, 88 insertions(+), 10 deletions(-) diff --git a/components/AddContributorsHeader/add-contributors-header.tsx b/components/AddContributorsHeader/add-contributors-header.tsx index 14e07f35e1..7623851a84 100644 --- a/components/AddContributorsHeader/add-contributors-header.tsx +++ b/components/AddContributorsHeader/add-contributors-header.tsx @@ -81,9 +81,10 @@ const AddContributorsHeader = ({
-
-
- ); }; export default Search; diff --git a/components/molecules/ContributorHighlight/contributor-highlight-card.tsx b/components/molecules/ContributorHighlight/contributor-highlight-card.tsx index bc62c3797a..a1aa47fa63 100644 --- a/components/molecules/ContributorHighlight/contributor-highlight-card.tsx +++ b/components/molecules/ContributorHighlight/contributor-highlight-card.tsx @@ -794,6 +794,7 @@ const ContributorHighlightCard = ({ setContributorSearch(value)} diff --git a/components/molecules/TableHeader/table-header.tsx b/components/molecules/TableHeader/table-header.tsx index f440cd7b2e..e0b59a92bc 100644 --- a/components/molecules/TableHeader/table-header.tsx +++ b/components/molecules/TableHeader/table-header.tsx @@ -88,6 +88,7 @@ const TableHeader = ({ title, metaInfo, entity, onSearch, layout, onLayoutToggle {onSearch ? ( handleChange(value)} placeholder="Enter email address" + labelText="Enter email address" name="search" className="flex-1 text-base" /> diff --git a/components/organisms/InsightPage/InsightPage.tsx b/components/organisms/InsightPage/InsightPage.tsx index 5d9ab874d4..6cdebab0e5 100644 --- a/components/organisms/InsightPage/InsightPage.tsx +++ b/components/organisms/InsightPage/InsightPage.tsx @@ -581,6 +581,7 @@ const InsightPage = ({ edit, insight, pageRepos, workspaceId }: InsightPageProps From d47a3860cfec1216bebf9e9c777126a1e48a1db2 Mon Sep 17 00:00:00 2001 From: shubhamchasing Date: Wed, 16 Oct 2024 16:56:17 +0530 Subject: [PATCH 04/10] fix: replace