Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: odd emoji style on highlights on small screens #1509

Closed
1 of 2 tasks
a0m0rajab opened this issue Aug 6, 2023 · 5 comments
Closed
1 of 2 tasks

Bug: odd emoji style on highlights on small screens #1509

a0m0rajab opened this issue Aug 6, 2023 · 5 comments
Labels
blocked 🎨 style Visual issues not impacting functionality
Milestone

Comments

@a0m0rajab
Copy link
Contributor

Describe the bug

While browsing the site, I found this as odd behavior, the emojis at the bottom of the card is not aligned.

image

Steps to reproduce

  1. go to highlights feed
  2. go to a card with 4-5 emoji reactions
  3. you will see the issue

Browsers

No response

Additional context (Is this in dev or production?)

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct

Contributing Docs

  • I agree to follow this project's Contribution Docs
@a0m0rajab a0m0rajab added 🐛 bug Something isn't working 👀 needs triage labels Aug 6, 2023
@brandonroberts brandonroberts added 🎨 style Visual issues not impacting functionality and removed 🐛 bug Something isn't working 👀 needs triage labels Aug 7, 2023
@brandonroberts brandonroberts added this to the Papercuts milestone Aug 7, 2023
@takanome-dev
Copy link
Contributor

@a0m0rajab which browser did you noticed this?

Tested in Brave Browser and looks good

emojis-alignments

@a0m0rajab
Copy link
Contributor Author

Chrome, a thing that I forgot to write, this is happening on small screens:
image

@a0m0rajab a0m0rajab changed the title Bug: odd emoji style on highlights Bug: odd emoji style on highlights on small screens Aug 7, 2023
@Satoshi-Sh
Copy link
Contributor

On it. .take

@Satoshi-Sh
Copy link
Contributor

Satoshi-Sh commented Oct 31, 2023

I spent lots of time on this.

The problem is the Emoji component (contributor-hilight-card.tsx) has a hardcoded style inside. We cannot override it.

<span style="width: 1em; height: 1em; margin: 0px 0.05em 0px 0.1em; vertical-align: -0.1em;">👀</span>

Here is the related discussion.
tommoor/react-emoji-render#48 (comment)

We might need to take another approach or make a pull request on the library. I will unassign myself for now.

@a0m0rajab
Copy link
Contributor Author

@brandonroberts FYI: the emojis is still not aligned with the number

image

it will be even weirder when you have double digits:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked 🎨 style Visual issues not impacting functionality
Projects
No open projects
Development

No branches or pull requests

5 participants