Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: remove npm 8.5.3 #611

Merged
merged 1 commit into from
May 27, 2022
Merged

ci: remove npm 8.5.3 #611

merged 1 commit into from
May 27, 2022

Conversation

koonpeng
Copy link
Collaborator

What's new

The npm script bug has been fixed so we can remove the alternative matrix now.
Fixes #559.

Self-checks

  • I have prototyped this new feature (if necessary) on Figma
  • I'm familiar with and follow this Typescript guideline
  • I added unit-tests for new components
  • I tried testing edge cases
  • I tested the behavior of the components that interact with the backend, with an e2e test

Discussion

Signed-off-by: Teo Koon Peng <[email protected]>
@koonpeng koonpeng requested a review from aaronchongth May 25, 2022 02:58
@codecov
Copy link

codecov bot commented May 25, 2022

Codecov Report

Merging #611 (03902ad) into main (987fdf3) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #611   +/-   ##
=======================================
  Coverage   75.87%   75.87%           
=======================================
  Files         312      312           
  Lines        6026     6026           
  Branches      642      650    +8     
=======================================
  Hits         4572     4572           
+ Misses       1264     1262    -2     
- Partials      190      192    +2     
Flag Coverage Δ
api-server 81.41% <ø> (ø)
dashboard 62.30% <ø> (ø)
reporting-server 77.88% <ø> (ø)
rmf-auth ∅ <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/dashboard/src/utils.ts 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 987fdf3...03902ad. Read the comment docs.

Copy link
Member

@aaronchongth aaronchongth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for monitoring the fix!

@aaronchongth aaronchongth merged commit 1e297fc into main May 27, 2022
@aaronchongth aaronchongth deleted the ci/remove-npm-8.5.3 branch May 27, 2022 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants