Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct OQS_MINIMAL_BUILD logic when introducing new optimizations #1138

Open
baentsch opened this issue Nov 30, 2021 · 0 comments
Open

Correct OQS_MINIMAL_BUILD logic when introducing new optimizations #1138

baentsch opened this issue Nov 30, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@baentsch
Copy link
Member

The implementation of this feature is brittle when new optimizations/cmake-subtargets are introduced (as was the case with #1117): Using the feature then leads to "strange" performance drops (vs. building all algorithms without this build option):

# Case 3, platform specific
implements effectively a white-list of cmake-build sub-targets that needs extension when adding new optimization targets. Maybe another way to handle this would be better (though can't think of one myself given a lack of understanding of cmake). Otherwise, this issue is to remind future implementors of new optimizations to add them at the above code location.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Todo
Development

No branches or pull requests

1 participant