Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The console display of dimm present do not match the hardware. #127

Open
MengLiMarkham opened this issue Feb 27, 2018 · 2 comments
Open

Comments

@MengLiMarkham
Copy link

P9 hostboot code will get and display the dimms which are present in the system as below:

        TARGETING::TYPE l_type = target->getAttr<TARGETING::ATTR_TYPE>();
        TARGETING::ATTR_FAPI_POS_type l_pos = 0;
        if( target->tryGetAttr<TARGETING::ATTR_FAPI_POS>(l_pos) )
        {
            l_presData[l_type] |= (0x8000000000000000 >> l_pos);
        }

In P8 we use ATTR_POSITION, that's ok for P8. But in P9 hostboot ATTR_FAPI_POS will over 64, and when shift over 64, overlapping happened, then these dimms can not be displayed in the console log as preset.
https://github.com/open-power/hostboot/blob/master/src/usr/isteps/istep06/host_discover_targets.C#L501

@dcrowell77
Copy link
Collaborator

This issue has been reported elsewhere too... The problem is that we don't really have a good position value to use that is consistent across all system types and all the target types that we want to display.

The best answer would be if we actually settled on a universal numbering scheme controlled via the MRW that actually matched the documentation for a particular system.

@ghost
Copy link

ghost commented Mar 1, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants