From 14fc45bd4d61d4414f719727ac5eabe9c29c1725 Mon Sep 17 00:00:00 2001
From: Brian Barrett <bbarrett@amazon.com>
Date: Tue, 8 Oct 2024 11:27:30 -0700
Subject: [PATCH] Disable silent-rules on CI

When CI fails with weird compiler / linker issues, it is frequently
easier to debug when we have the exact compiler / linker flags that
were used.  Disable silent rules (ie, run like make V=1) when building
under CI.

Signed-off-by: Brian Barrett <bbarrett@amazon.com>
---
 .ci/community-jenkins/pr-builder.sh | 1 +
 .github/workflows/compile-cuda.yaml | 2 +-
 .github/workflows/compile-rocm.yaml | 2 +-
 .github/workflows/compile-ze.yaml   | 2 +-
 .github/workflows/macos-checks.yaml | 2 +-
 .github/workflows/ompi_mpi4py.yaml  | 1 +
 6 files changed, 6 insertions(+), 4 deletions(-)

diff --git a/.ci/community-jenkins/pr-builder.sh b/.ci/community-jenkins/pr-builder.sh
index d721e365624..eb88b4c1538 100755
--- a/.ci/community-jenkins/pr-builder.sh
+++ b/.ci/community-jenkins/pr-builder.sh
@@ -192,6 +192,7 @@ case ${PLATFORM_ID} in
         CONFIGURE_ARGS="$CONFIGURE_ARGS LDFLAGS=-Wl,-rpath,/usr/local/lib/gcc5 --with-wrapper-ldflags=-Wl,-rpath,/usr/local/lib/gcc5"
         ;;
 esac
+CONFIGURE_ARGS="$CONFIGURE_ARGS --disable-silent-rules"
 
 echo "--> Compiler setup: $CONFIGURE_ARGS"
 
diff --git a/.github/workflows/compile-cuda.yaml b/.github/workflows/compile-cuda.yaml
index 0bddcd3c744..97d89372ce0 100644
--- a/.github/workflows/compile-cuda.yaml
+++ b/.github/workflows/compile-cuda.yaml
@@ -24,5 +24,5 @@ jobs:
     - name: Build Open MPI
       run: |
         ./autogen.pl
-        ./configure --prefix=${PWD}/install --with-cuda=${CUDA_PATH} --with-cuda-libdir=${CUDA_PATH}/lib64/stubs
+        ./configure --prefix=${PWD}/install --with-cuda=${CUDA_PATH} --with-cuda-libdir=${CUDA_PATH}/lib64/stubs --disable-silent-rules
         make -j
diff --git a/.github/workflows/compile-rocm.yaml b/.github/workflows/compile-rocm.yaml
index 6db935a1a31..22af463a164 100644
--- a/.github/workflows/compile-rocm.yaml
+++ b/.github/workflows/compile-rocm.yaml
@@ -27,5 +27,5 @@ jobs:
     - name: Build Open MPI
       run: |
         ./autogen.pl
-        ./configure --prefix=${PWD}/install --with-rocm=/opt/rocm --disable-mpi-fortran
+        ./configure --prefix=${PWD}/install --with-rocm=/opt/rocm --disable-mpi-fortran --disable-silent-rules
         LD_LIBRARY_PATH=/opt/rocm/lib make -j
diff --git a/.github/workflows/compile-ze.yaml b/.github/workflows/compile-ze.yaml
index 06e217d49a5..0fb1e2d1057 100644
--- a/.github/workflows/compile-ze.yaml
+++ b/.github/workflows/compile-ze.yaml
@@ -27,5 +27,5 @@ jobs:
         #
         # we have to disable romio as its old ze stuff doesn't compile with supported ZE API
         #
-        ./configure --prefix=${PWD}/install --disable-mpi-fortran --disable-io-romio --disable-oshmem --with-ze
+        ./configure --prefix=${PWD}/install --disable-mpi-fortran --disable-io-romio --disable-oshmem --with-ze --disable-silent-rules
         make -j
diff --git a/.github/workflows/macos-checks.yaml b/.github/workflows/macos-checks.yaml
index f207f536070..5c50a8fe114 100644
--- a/.github/workflows/macos-checks.yaml
+++ b/.github/workflows/macos-checks.yaml
@@ -25,7 +25,7 @@ jobs:
     - name: Build Open MPI
       run: |
         ./autogen.pl
-        ./configure --prefix=/opt/openmpi
+        ./configure --prefix=/opt/openmpi --disable-silent-rules
         make -j $(sysctl -n hw.logicalcpu)
     - name: Run unit tests
       run: |
diff --git a/.github/workflows/ompi_mpi4py.yaml b/.github/workflows/ompi_mpi4py.yaml
index 3bc950da5b8..7df4939e5e7 100644
--- a/.github/workflows/ompi_mpi4py.yaml
+++ b/.github/workflows/ompi_mpi4py.yaml
@@ -54,6 +54,7 @@ jobs:
               --disable-sphinx
               --disable-mpi-fortran
               --disable-oshmem
+              --disable-silent-rules
               --prefix=/opt/openmpi
               LDFLAGS=-Wl,-rpath,/opt/openmpi/lib
       working-directory: mpi-build