From edb33eea4d0b3d73e54b78167764cfbf3086c3cd Mon Sep 17 00:00:00 2001 From: Tai-Wang Date: Mon, 24 Aug 2020 17:00:42 +0800 Subject: [PATCH 1/2] Fix a minor bug in json2csv of lyft dataset --- mmdet3d/datasets/lyft_dataset.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/mmdet3d/datasets/lyft_dataset.py b/mmdet3d/datasets/lyft_dataset.py index 837fa79f4c..a2df498c54 100644 --- a/mmdet3d/datasets/lyft_dataset.py +++ b/mmdet3d/datasets/lyft_dataset.py @@ -433,8 +433,7 @@ def json2csv(json_path, csv_savepath): json_path (str): Path of the result json file. csv_savepath (str): Path to save the csv file. """ - with open(json_path, 'r') as f: - results = mmcv.load(f)['results'] + results = mmcv.load(json_path)['results'] csv_nopred = 'data/lyft/sample_submission.csv' data = pd.read_csv(csv_nopred) Id_list = list(data['Id']) From 02a74a8cc10d706b9327bd89246e731b5168552c Mon Sep 17 00:00:00 2001 From: Tai-Wang Date: Tue, 25 Aug 2020 15:24:01 +0800 Subject: [PATCH 2/2] Fix variable names and minor hard code --- mmdet3d/datasets/lyft_dataset.py | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/mmdet3d/datasets/lyft_dataset.py b/mmdet3d/datasets/lyft_dataset.py index a2df498c54..c69e027506 100644 --- a/mmdet3d/datasets/lyft_dataset.py +++ b/mmdet3d/datasets/lyft_dataset.py @@ -425,8 +425,7 @@ def show(self, results, out_dir): pred_bboxes[..., 2] += pred_bboxes[..., 5] / 2 show_result(points, gt_bboxes, pred_bboxes, out_dir, file_name) - @staticmethod - def json2csv(json_path, csv_savepath): + def json2csv(self, json_path, csv_savepath): """Convert the json file to csv format for submission. Args: @@ -434,8 +433,8 @@ def json2csv(json_path, csv_savepath): csv_savepath (str): Path to save the csv file. """ results = mmcv.load(json_path)['results'] - csv_nopred = 'data/lyft/sample_submission.csv' - data = pd.read_csv(csv_nopred) + sample_list_path = osp.join(self.data_root, 'sample_submission.csv') + data = pd.read_csv(sample_list_path) Id_list = list(data['Id']) pred_list = list(data['PredictionString']) cnt = 0