Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Sync the seed in diff ranks. #744

Merged
merged 2 commits into from
Mar 25, 2022

Conversation

yingfhu
Copy link
Collaborator

@yingfhu yingfhu commented Mar 23, 2022

Motivation

This is an implantation from MMDet #7432 and #7440.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the backward compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here and update the documentation.

Checklist

Before PR:

  • Pre-commit or other linting tools are used to fix the potential lint issues.
  • Bug fixes are fully covered by unit tests, the case that causes the bug should be added in the unit tests.
  • The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, like docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with those projects, like MMDet or MMSeg.
  • CLA has been signed and all committers have signed the CLA in this PR.

@yingfhu yingfhu requested review from mzr1996 and 0x4f5da2 and removed request for mzr1996 March 23, 2022 12:46
@codecov
Copy link

codecov bot commented Mar 23, 2022

Codecov Report

Merging #744 (0d473cc) into dev (a19c28f) will decrease coverage by 0.04%.
The diff coverage is 70.83%.

@@            Coverage Diff             @@
##              dev     #744      +/-   ##
==========================================
- Coverage   85.15%   85.11%   -0.05%     
==========================================
  Files         124      124              
  Lines        7672     7690      +18     
  Branches     1325     1328       +3     
==========================================
+ Hits         6533     6545      +12     
- Misses        946      951       +5     
- Partials      193      194       +1     
Flag Coverage Δ
unittests 85.01% <70.83%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmcls/datasets/builder.py 91.04% <ø> (ø)
mmcls/core/utils/dist_utils.py 32.07% <60.00%> (+8.99%) ⬆️
mmcls/datasets/samplers/repeat_aug.py 90.90% <75.00%> (+0.43%) ⬆️
mmcls/core/utils/__init__.py 100.00% <100.00%> (ø)
mmcls/datasets/samplers/distributed_sampler.py 85.18% <100.00%> (+1.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a19c28f...0d473cc. Read the comment docs.

Copy link
Member

@mzr1996 mzr1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@mzr1996 mzr1996 merged commit 995f291 into open-mmlab:dev Mar 25, 2022
@mzr1996 mzr1996 changed the title [Feature] Add diff seeds to diff ranks. [Feature] Sync the seed in diff ranks. Mar 25, 2022
mzr1996 pushed a commit to mzr1996/mmpretrain that referenced this pull request Nov 24, 2022
* [Feature] Add diff seeds to diff ranks.

* lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants