Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Fix logo url link from mmocr to mmclassification. #732

Merged
merged 1 commit into from
Mar 23, 2022

Conversation

Hydrion-Qlz
Copy link
Contributor

@Hydrion-Qlz Hydrion-Qlz commented Mar 16, 2022

Motivation

When i read the mmclassification zh_CN docs, i click the logo on left top, which redirect me to mmocr.readthedocs.io, after reading the source, i find it was a little bug

Modification

i modify the file in docs/zh_CN/conf.py :91, and modify the link from https://mmocr.readthedocs.io/zh_CN/latest/ to https://mmclassification.readthedocs.io/zh_CN/latest/

BC-breaking (Optional)

No

Use cases (Optional)

No

Checklist

Before PR:

  • Pre-commit or other linting tools are used to fix the potential lint issues.
  • Bug fixes are fully covered by unit tests, the case that causes the bug should be added in the unit tests.
  • The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, like docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with those projects, like MMDet or MMSeg.
  • CLA has been signed and all committers have signed the CLA in this PR.

@CLAassistant
Copy link

CLAassistant commented Mar 16, 2022

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@mzr1996 mzr1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good

@mzr1996 mzr1996 changed the title [fix] fix logo url link from mmocr to mmclassification [Docs] Fix logo url link from mmocr to mmclassification. Mar 23, 2022
@mzr1996 mzr1996 merged commit 84654b1 into open-mmlab:master Mar 23, 2022
@Hydrion-Qlz Hydrion-Qlz deleted the CLA-fix branch March 23, 2022 07:28
mzr1996 pushed a commit to mzr1996/mmpretrain that referenced this pull request Nov 24, 2022
@OpenMMLab-Assistant003
Copy link

Hi @Hydrion-Qlz!First of all, we want to express our gratitude for your significant PR in the MMClassification project. Your contribution is highly appreciated, and we are grateful for your efforts in helping improve this open-source project during your personal time. We believe that many developers will benefit from your PR.

We would also like to invite you to join our Special Interest Group (SIG) private channel on Discord, where you can share your experiences, ideas, and build connections with like-minded peers. To join the SIG channel, simply message moderator— OpenMMLab on Discord or briefly share your open-source contributions in the #introductions channel and we will assist you. Look forward to seeing you there! Join us :https://discord.gg/raweFPmdzG

If you are Chinese or have WeChat,welcome to join our community on WeChat. You can add our assistant :openmmlabwx. Please add "mmsig + Github ID" as a remark when adding friends:)
Thank you again for your contribution❤ @Hydrion-Qlz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants