Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add Twins backbone and convert checkpoints #642

Merged
merged 19 commits into from
Jan 27, 2022
Merged

[Feature] Add Twins backbone and convert checkpoints #642

merged 19 commits into from
Jan 27, 2022

Conversation

Ezra-Yu
Copy link
Collaborator

@Ezra-Yu Ezra-Yu commented Jan 11, 2022

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Add twins backbone and convert checkpoints

Modification

  • support backbone
  • convert checkpoints
  • add readme and yaml
  • add unit tests
  • Organize configuration files

Checklist

Before PR:

  • Pre-commit or other linting tools are used to fix the potential lint issues.
  • Bug fixes are fully covered by unit tests, the case that causes the bug should be added in the unit tests.
  • The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, like docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with those projects, like MMDet or MMSeg.
  • CLA has been signed and all committers have signed the CLA in this PR.

@codecov
Copy link

codecov bot commented Jan 11, 2022

Codecov Report

Merging #642 (8e4a496) into dev (a451d63) will increase coverage by 0.50%.
The diff coverage is 98.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #642      +/-   ##
==========================================
+ Coverage   82.27%   82.77%   +0.50%     
==========================================
  Files         120      122       +2     
  Lines        7045     7270     +225     
  Branches     1228     1263      +35     
==========================================
+ Hits         5796     6018     +222     
- Misses       1075     1076       +1     
- Partials      174      176       +2     
Flag Coverage Δ
unittests 82.77% <98.66%> (+0.50%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmcls/models/backbones/twins.py 98.54% <98.54%> (ø)
mmcls/models/backbones/__init__.py 100.00% <100.00%> (ø)
mmcls/models/utils/__init__.py 100.00% <100.00%> (ø)
mmcls/models/utils/position_encoding.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a451d63...8e4a496. Read the comment docs.

@mzr1996 mzr1996 changed the base branch from master to dev January 13, 2022 04:25
@Ezra-Yu Ezra-Yu changed the title [Feature] Add twins backbone [Feature] Add Twins backbone and convert checkpoints Jan 21, 2022
@Ezra-Yu Ezra-Yu requested a review from mzr1996 January 21, 2022 08:03
tools/convert_models/twins2mmcls.py Outdated Show resolved Hide resolved
mmcls/models/backbones/twins.py Outdated Show resolved Hide resolved
mmcls/models/backbones/twins.py Show resolved Hide resolved
mmcls/models/backbones/twins.py Show resolved Hide resolved
mmcls/models/backbones/twins.py Outdated Show resolved Hide resolved
mmcls/models/backbones/twins.py Outdated Show resolved Hide resolved
mmcls/models/backbones/twins.py Outdated Show resolved Hide resolved
mmcls/models/backbones/twins.py Outdated Show resolved Hide resolved
@Ezra-Yu Ezra-Yu requested a review from mzr1996 January 25, 2022 15:43
configs/twins/README.md Outdated Show resolved Hide resolved
configs/twins/twins.yml Outdated Show resolved Hide resolved
@Ezra-Yu Ezra-Yu requested a review from mzr1996 January 26, 2022 09:16
Copy link
Member

@mzr1996 mzr1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mzr1996 mzr1996 merged commit 94eb3ff into dev Jan 27, 2022
@mzr1996 mzr1996 mentioned this pull request Jan 29, 2022
27 tasks
Ezra-Yu added a commit to Ezra-Yu/mmclassification that referenced this pull request Feb 14, 2022
* add twins backbone

* add position_encoding

* refactor twins

* Supplemental unit tests

* update docstring and readme

* update docstring and readme

* update docstring and readme

* update docstring

* update docstring

* update docstring

* update docstring

* remove note

* update doc and docstring

* update docstring

* update docstring

* use abstract pdf link and rename yamlfile

* Update model link

Co-authored-by: mzr1996 <[email protected]>
@Ezra-Yu Ezra-Yu deleted the add-twins branch March 3, 2022 06:53
mzr1996 added a commit to mzr1996/mmpretrain that referenced this pull request Nov 24, 2022
* add twins backbone

* add position_encoding

* refactor twins

* Supplemental unit tests

* update docstring and readme

* update docstring and readme

* update docstring and readme

* update docstring

* update docstring

* update docstring

* update docstring

* remove note

* update doc and docstring

* update docstring

* update docstring

* use abstract pdf link and rename yamlfile

* Update model link

Co-authored-by: mzr1996 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants