Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor] Remove deprecation #633

Merged
merged 8 commits into from
Feb 10, 2022
Merged

Conversation

mzr1996
Copy link
Member

@mzr1996 mzr1996 commented Jan 6, 2022

Motivation

Several components have been deprecated for a long time. Remove them now.

Modification

  1. Remove deprecated --options in some tools
  2. Remove deprecated eval hooks and fp16 hooks
  3. Remove deprecated mixup&cutmix and return_tuple arguments.
  4. Remove deprecated deprecated_options in the multi-label dataset
  5. Remove deprecated formating.py
  6. Remove deprecated default mode of LabelSmoothLoss

BC-breaking (Optional)

These components or options have been deprecated for a long time, users should have stopped using them.

Checklist

Before PR:

  • Pre-commit or other linting tools are used to fix the potential lint issues.
  • Bug fixes are fully covered by unit tests, the case that causes the bug should be added in the unit tests.
  • The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, like docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with those projects, like MMDet or MMSeg.
  • CLA has been signed and all committers have signed the CLA in this PR.

@mzr1996 mzr1996 requested a review from Ezra-Yu January 6, 2022 07:29
@codecov
Copy link

codecov bot commented Jan 6, 2022

Codecov Report

Merging #633 (c397926) into dev (a7f8e96) will increase coverage by 1.85%.
The diff coverage is 71.42%.

❗ Current head c397926 differs from pull request most recent head a9ec30e. Consider uploading reports for the commit a9ec30e to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #633      +/-   ##
==========================================
+ Coverage   83.15%   85.01%   +1.85%     
==========================================
  Files         126      120       -6     
  Lines        7630     7362     -268     
  Branches     1332     1271      -61     
==========================================
- Hits         6345     6259      -86     
+ Misses       1095      915     -180     
+ Partials      190      188       -2     
Flag Coverage Δ
unittests 85.01% <71.42%> (+1.85%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmcls/core/__init__.py 100.00% <ø> (ø)
mmcls/core/evaluation/__init__.py 100.00% <ø> (ø)
mmcls/datasets/multi_label.py 80.55% <ø> (+5.55%) ⬆️
mmcls/models/losses/label_smooth_loss.py 100.00% <ø> (ø)
mmcls/models/classifiers/image.py 91.30% <50.00%> (+6.42%) ⬆️
mmcls/apis/train.py 19.17% <100.00%> (-1.56%) ⬇️
mmcls/models/classifiers/base.py 76.31% <100.00%> (+1.92%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7f8e96...a9ec30e. Read the comment docs.

@mzr1996 mzr1996 changed the base branch from master to dev January 13, 2022 04:27
@mzr1996 mzr1996 force-pushed the remove-deprecation branch from 3251027 to bd9bbce Compare January 28, 2022 03:16
@mzr1996 mzr1996 force-pushed the remove-deprecation branch from bd9bbce to 7c4fd39 Compare February 9, 2022 10:30
Copy link
Collaborator

@Ezra-Yu Ezra-Yu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mzr1996 mzr1996 merged commit bca695b into open-mmlab:dev Feb 10, 2022
mzr1996 added a commit to mzr1996/mmpretrain that referenced this pull request Nov 24, 2022
* Remove deprecated `--options` in some tools

* Remove deprecated eval hooks and fp16 hooks

* Remove deprecated mixup&cutmix, pretrained and return_tuple arguments.

* Remove deprecated `deprecated_options` in multi label dataset

* Remove deprecated `formating.py`

* Remove deprecated default mode of `LabelSmoothLoss`

* Revert pretrained argument, and remove it's deprecation sign.

* Update unit test
@mzr1996 mzr1996 deleted the remove-deprecation branch December 7, 2022 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants