Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] LAMB optimizer #591

Merged
merged 5 commits into from
Dec 13, 2021
Merged

[Feature] LAMB optimizer #591

merged 5 commits into from
Dec 13, 2021

Conversation

0x4f5da2
Copy link
Contributor

@0x4f5da2 0x4f5da2 commented Dec 8, 2021

Motivation

The 'ResNet Strikes Back' requires LAMB optimizer

Modification

Add LAMB optimizer

@codecov
Copy link

codecov bot commented Dec 8, 2021

Codecov Report

Merging #591 (858260d) into master (58ab028) will decrease coverage by 0.83%.
The diff coverage is 0.00%.

❗ Current head 858260d differs from pull request most recent head 3182a22. Consider uploading reports for the commit 3182a22 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #591      +/-   ##
==========================================
- Coverage   80.01%   79.17%   -0.84%     
==========================================
  Files         109      111       +2     
  Lines        6419     6487      +68     
  Branches     1102     1117      +15     
==========================================
  Hits         5136     5136              
- Misses       1146     1214      +68     
  Partials      137      137              
Flag Coverage Δ
unittests 79.17% <0.00%> (-0.84%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmcls/core/optimizers/__init__.py 0.00% <0.00%> (ø)
mmcls/core/optimizers/lamb.py 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58ab028...3182a22. Read the comment docs.

Copy link
Member

@mzr1996 mzr1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mzr1996 mzr1996 merged commit 851b438 into open-mmlab:master Dec 13, 2021
mzr1996 added a commit to mzr1996/mmpretrain that referenced this pull request Nov 24, 2022
* impl lamb

* Add unit tests

* Fix unit test

* Fix unit tests

* Use list instead of tuple in `__all__` according to PEP8

Co-authored-by: mzr1996 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants