Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Reproduction] Reproduce RegNetX training accuracy. #587

Merged
merged 38 commits into from
Dec 28, 2021

Conversation

Ezra-Yu
Copy link
Collaborator

@Ezra-Yu Ezra-Yu commented Dec 6, 2021

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the backward compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here and update the documentation.

Checklist

Before PR:

  • Pre-commit or other linting tools are used to fix the potential lint issues.
  • Bug fixes are fully covered by unit tests, the case that causes the bug should be added in the unit tests.
  • The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, like docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with those projects, like MMDet or MMSeg.
  • CLA has been signed and all committers have signed the CLA in this PR.

@codecov
Copy link

codecov bot commented Dec 6, 2021

Codecov Report

Merging #587 (d8c6afc) into master (159b38d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #587   +/-   ##
=======================================
  Coverage   81.77%   81.77%           
=======================================
  Files         118      118           
  Lines        6814     6814           
  Branches     1174     1174           
=======================================
  Hits         5572     5572           
  Misses       1082     1082           
  Partials      160      160           
Flag Coverage Δ
unittests 81.77% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 159b38d...d8c6afc. Read the comment docs.

@Ezra-Yu Ezra-Yu requested a review from mzr1996 December 15, 2021 09:16
@mzr1996 mzr1996 changed the title Add Regnetx train [Reproduction] Reproduce RegNetX training accuracy. Dec 22, 2021
Copy link
Member

@mzr1996 mzr1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mzr1996 mzr1996 merged commit e7c06b8 into open-mmlab:master Dec 28, 2021
mzr1996 pushed a commit to mzr1996/mmpretrain that referenced this pull request Nov 24, 2022
* add preciseBN hook

* add precise-bn config

* add proority of preciseBN

* Add precise BN hook

* Update PreciseBN hook

* add config example & pre-commit

* Update PBN

* Add unit test

* Update unit tests

* mv preciseBN to mmcls.runner

* rm extra sleep()

* merge latest

* update code

* fix lint

* update unit tests

* add regnetx configs

* update prcise BN in configs

* fix lint

* add checkpoints and logs

* fix conflict

* fix lint

* update model_zoo and model-index

* remove some changes

* update readme.md

* remove precise_bn.py
@Ezra-Yu Ezra-Yu deleted the regnetx branch April 13, 2023 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants