Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix vit config and model broken links #564

Merged
merged 5 commits into from
Nov 30, 2021

Conversation

Ezra-Yu
Copy link
Collaborator

@Ezra-Yu Ezra-Yu commented Nov 29, 2021

Motivation

Fix vit config and model broken links #562

Modification

Fix vit config and model broken links

Checklist

Before PR:

  • Pre-commit or other linting tools are used to fix the potential lint issues.
  • Bug fixes are fully covered by unit tests, the case that causes the bug should be added in the unit tests.
  • The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, like docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with those projects, like MMDet or MMSeg.
  • CLA has been signed and all committers have signed the CLA in this PR.

@codecov
Copy link

codecov bot commented Nov 29, 2021

Codecov Report

Merging #564 (9accaca) into master (6e69f91) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #564   +/-   ##
=======================================
  Coverage   79.92%   79.92%           
=======================================
  Files         107      107           
  Lines        6102     6102           
  Branches     1040     1040           
=======================================
  Hits         4877     4877           
  Misses       1093     1093           
  Partials      132      132           
Flag Coverage Δ
unittests 79.92% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e69f91...9accaca. Read the comment docs.

@Ezra-Yu Ezra-Yu requested a review from mzr1996 November 30, 2021 02:39
Copy link
Member

@mzr1996 mzr1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, closing #562

@mzr1996 mzr1996 merged commit 4ddfd3d into open-mmlab:master Nov 30, 2021
@Ezra-Yu Ezra-Yu deleted the fix-vit-link branch July 18, 2022 08:45
mzr1996 pushed a commit to mzr1996/mmpretrain that referenced this pull request Nov 24, 2022
* Update model_zoo.md

* Update model_zoo.md

* fix config link

* fix config link
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants