-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enhance] Added NumClassCheckHook and CI tests #559
[Enhance] Added NumClassCheckHook and CI tests #559
Conversation
Thanks for your contribution, we will review it soon~ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- please build a local HOOK registry to avoid conflict of repeat registration into the HOOK registrar of MMCV refer to [Fix] Use local ATTENTION registry to avoid conflict with other repo. #375
- please make a
/mmcls/core/hook
folder and remove this hook in that folder, so that users can find this helpful feature easily. like https://github.com/open-mmlab/mmdetection/tree/master/mmdet/core/hook
Codecov Report
@@ Coverage Diff @@
## master #559 +/- ##
==========================================
+ Coverage 80.01% 80.03% +0.02%
==========================================
Files 109 111 +2
Lines 6419 6446 +27
Branches 1102 1108 +6
==========================================
+ Hits 5136 5159 +23
- Misses 1146 1150 +4
Partials 137 137
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
And please merge the latest master branch at first, because we made some changes about CI. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* Added NumClassCheckHook and CI tests * Added HOOKS local registry. NumClassCheckHook and unit test files redistribution. * Extended hook for supporting IterRunner & EpochRunner. Extended unit test. * Simplification of ClassNumCheckHook. Minor changes.
Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
Extend and adapt NumClassCheckHook for working with mmcls library. The hook is very convenient for checking if your model classes number is equal to the dataset classes number and detect early mistakes in the training pipeline.
Modification
I added the NumClassCheckHook, adapting it to the mmcls environment. I also added an unit test for checking the correct working of the hook.
Checklist
Before PR:
After PR: