Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dependency] Update mmcv dependency version #509

Merged
merged 2 commits into from
Nov 2, 2021

Conversation

mzr1996
Copy link
Member

@mzr1996 mzr1996 commented Nov 2, 2021

Motivation

The new version mmcv has fixed many bugs and supports ceph backend. We will migrate to the new version mmcv.

Modification

As the title

Checklist

Before PR:

  • Pre-commit or other linting tools are used to fix the potential lint issues.
  • Bug fixes are fully covered by unit tests, the case that causes the bug should be added in the unit tests.
  • The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, like docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with those projects, like MMDet or MMSeg.
  • CLA has been signed and all committers have signed the CLA in this PR.

@mzr1996 mzr1996 requested a review from Ezra-Yu November 2, 2021 09:03
@codecov
Copy link

codecov bot commented Nov 2, 2021

Codecov Report

Merging #509 (db91e1f) into master (b8c3825) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #509   +/-   ##
=======================================
  Coverage   79.42%   79.42%           
=======================================
  Files         106      106           
  Lines        5959     5959           
  Branches      962      962           
=======================================
  Hits         4733     4733           
  Misses       1095     1095           
  Partials      131      131           
Flag Coverage Δ
unittests 79.42% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmcls/__init__.py 89.65% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8c3825...db91e1f. Read the comment docs.

Copy link
Collaborator

@Ezra-Yu Ezra-Yu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mzr1996 mzr1996 merged commit d1473e4 into open-mmlab:master Nov 2, 2021
mzr1996 added a commit to mzr1996/mmpretrain that referenced this pull request Nov 24, 2022
* Update mmcv dependency version

* Add code info in some metafiles
@mzr1996 mzr1996 deleted the update-deps branch December 7, 2022 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants