[Refactor] Refactor Resize transform and add Pad transform.
#506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0x4f5da2
added
WIP
Community discussion
Reproduction
Codecov Report
@@ Coverage Diff @@
## master #506 +/- ##
==========================================
+ Coverage 79.42% 79.62% +0.19%
==========================================
Files 106 106
Lines 5959 6002 +43
Branches 962 972 +10
==========================================
+ Hits 4733 4779 +46
+ Misses 1095 1093 -2
+ Partials 131 130 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
mzr1996
requested changes
Nov 5, 2021
mzr1996
changed the title
Resize transform and add Pad transform.
mzr1996
requested changes
Nov 8, 2021
mzr1996
pushed a commit
to mzr1996/mmpretrain
that referenced
this pull request
Nov 24, 2022
…-mmlab#506) * refactor resize, test tobe done * resize reimpl according to discussion; add pad * minor fixes and add tests * minor fixes on docstring * add additional unit test * reformat resize and pad * revise code and docstr according to the comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This pull request is base on issue#453
Modification
Refactor the
Resizeto enable resizing images while keeping the aspect ratio with padding.