[Fix] Remove DistSamplerSeedHook if use IterBasedRunner.
#501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Codecov Report
@@ Coverage Diff @@
## master #501 +/- ##
=======================================
Coverage 78.94% 78.94%
=======================================
Files 104 104
Lines 5760 5760
Branches 933 933
=======================================
Hits 4547 4547
Misses 1089 1089
Partials 124 124
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
mzr1996
requested changes
Oct 27, 2021
Co-authored-by: Ma Zerun <[email protected]>
mzr1996
changed the title
DistSamplerSeedHook if use IterBasedRunner.
mzr1996
added a commit
to mzr1996/mmpretrain
that referenced
this pull request
Nov 24, 2022
…lab#501) * remove DistSamplerSeedHook for IterBasedRunner * Register DistSamplerSeedHook for EpochBasedRunner only Co-authored-by: Ma Zerun <[email protected]> Co-authored-by: Ma Zerun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When using IterBasedRunner, it will raise the
AttributeError: 'IterBasedRunner' object has no attribute 'data_loader'in DistSamplerSeedHook during the before_epoch.According to the comments, there is no need to register the DistSamplerSeedHook for IterBasedRunner, so I remove it.
Modification
see the diff below
BC-breaking (Optional)
Does the modification introduce changes that break the backward compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
NO