Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Update metafile and Readme #435

Merged
merged 6 commits into from
Sep 18, 2021
Merged

Conversation

mzr1996
Copy link
Member

@mzr1996 mzr1996 commented Sep 8, 2021

Motivation

According to the new metafile standard to update our metafiles.
According to benchmark regression results to update some accuracy result in our readme. Refers to #283 and #288

Modification

  1. Add the paper title, code link, and code version information.
  2. Add third-party checkpoints source URL and code information.
  3. Add Readme and metafile of Transformer-in-Transformer.
  4. Update some outdated accuracy information in metafiles.
  5. Upload new checkpoints of ResNet to confirm reproducibility.

Checklist

Before PR:

  • Pre-commit or other linting tools are used to fix the potential lint issues.
  • Bug fixes are fully covered by unit tests, the case that causes the bug should be added in the unit tests.
  • The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, like docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with those projects, like MMDet or MMSeg.
  • CLA has been signed and all committers have signed the CLA in this PR.

@codecov
Copy link

codecov bot commented Sep 8, 2021

Codecov Report

Merging #435 (6f5ffb5) into master (a8f4f82) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #435      +/-   ##
==========================================
+ Coverage   77.27%   77.29%   +0.01%     
==========================================
  Files         100      100              
  Lines        5356     5356              
  Branches      883      883              
==========================================
+ Hits         4139     4140       +1     
  Misses       1098     1098              
+ Partials      119      118       -1     
Flag Coverage Δ
unittests 77.29% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmcls/models/backbones/swin_transformer.py 90.07% <0.00%> (+0.70%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8f4f82...6f5ffb5. Read the comment docs.

@mzr1996 mzr1996 requested a review from Ezra-Yu September 8, 2021 09:03
@mzr1996 mzr1996 added the Documentation Improvements or additions to documentation label Sep 9, 2021
Copy link
Collaborator

@Ezra-Yu Ezra-Yu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mzr1996 mzr1996 merged commit 8f68779 into open-mmlab:master Sep 18, 2021
README: configs/fp16/README.md
Code:
URI: https://github.com/open-mmlab/mmclassification/blob/a41cb2fa938d957101cc446e271486206188bf5b/mmcls/core/fp16/hooks.py#L13

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

URI -> URL?

@mzr1996 mzr1996 deleted the update-meta-yml branch July 20, 2022 07:09
mzr1996 added a commit to mzr1996/mmpretrain that referenced this pull request Nov 24, 2022
* Update metafile format.

* Update accuracy of checkpoints.

* Add metafile and readme for tnt.

* Add converted ckpts in swin-transformer.

* Fix tnt ckpt link

* Update swin_transformer metafile
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants