Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Add PR template and modify issue template #380

Merged
merged 4 commits into from
Aug 4, 2021

Conversation

mzr1996
Copy link
Member

@mzr1996 mzr1996 commented Jul 28, 2021

Motivation

Use PR template to standardized PR docs.
And add language suggestions in the Chinese issue templates to recommend users to use the English templates.

Modification

  1. Add PR template, refers to MMCV PR template.
  2. Add language suggestions in the Chinese issue templates.
  3. Add issue template config, refers to MMCV issue config.

Checklist

  • Pre-commit or other linting tools are used to fix the potential lint issues.
  • The modification is covered by complete unit tests. If not, please add more unit tests to ensure the correctness.
  • If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMSeg.
  • The documentation has been modified accordingly, like docstring or example tutorials.

@mzr1996 mzr1996 requested a review from Ezra-Yu July 28, 2021 06:36
@codecov
Copy link

codecov bot commented Jul 28, 2021

Codecov Report

Merging #380 (733f8ec) into master (c92eefb) will increase coverage by 0.48%.
The diff coverage is 98.19%.

❗ Current head 733f8ec differs from pull request most recent head c995050. Consider uploading reports for the commit c995050 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #380      +/-   ##
==========================================
+ Coverage   76.02%   76.51%   +0.48%     
==========================================
  Files          96       97       +1     
  Lines        5114     5224     +110     
  Branches      849      856       +7     
==========================================
+ Hits         3888     3997     +109     
  Misses       1108     1108              
- Partials      118      119       +1     
Flag Coverage Δ
unittests 76.51% <98.19%> (+0.48%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmcls/datasets/imagenet.py 24.48% <0.00%> (ø)
mmcls/datasets/pipelines/auto_augment.py 78.78% <ø> (ø)
mmcls/datasets/pipelines/transforms.py 86.81% <ø> (ø)
mmcls/models/backbones/tnt.py 99.08% <99.08%> (ø)
mmcls/models/backbones/__init__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c92eefb...c995050. Read the comment docs.

Copy link
Collaborator

@Ezra-Yu Ezra-Yu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK.

@mzr1996 mzr1996 merged commit 2aa4100 into open-mmlab:master Aug 4, 2021
@mzr1996 mzr1996 deleted the template branch August 13, 2021 09:51
mzr1996 added a commit to mzr1996/mmpretrain that referenced this pull request Nov 24, 2022
* Add language suggestion in issue-template

* Add issue template config

* Add PR template

* Update pr template according to mmcv open-mmlab#1228
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants