Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Fix patch_cfg argument bug in SwinTransformer #368

Merged
merged 2 commits into from
Jul 27, 2021

Conversation

Junjun2016
Copy link
Contributor

Fix merge dict error in SWIN.

@CLAassistant
Copy link

CLAassistant commented Jul 23, 2021

CLA assistant check
All committers have signed the CLA.

@mzr1996
Copy link
Member

mzr1996 commented Jul 27, 2021

Please merge the latest master branch and try again, thx

@Junjun2016
Copy link
Contributor Author

Hi @mzr1996
Please review it again!

Copy link
Member

@mzr1996 mzr1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Jul 27, 2021

Codecov Report

Merging #368 (0fcf56e) into master (99e3d4e) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #368   +/-   ##
=======================================
  Coverage   76.01%   76.01%           
=======================================
  Files          96       96           
  Lines        5112     5112           
  Branches      849      849           
=======================================
  Hits         3886     3886           
  Misses       1108     1108           
  Partials      118      118           
Flag Coverage Δ
unittests 76.01% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmcls/models/backbones/swin_transformer.py 90.90% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99e3d4e...0fcf56e. Read the comment docs.

@mzr1996 mzr1996 changed the title [Fix] Fix merge dict error [Fix] Fix patch_cfg argument bug in SwinTransformer Jul 27, 2021
@mzr1996 mzr1996 merged commit e3b77e7 into open-mmlab:master Jul 27, 2021
mzr1996 pushed a commit to mzr1996/mmpretrain that referenced this pull request Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants