Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Produce temperature setpoints in K #27

Closed
cprotopa opened this issue Apr 2, 2020 · 1 comment · Fixed by #28
Closed

Produce temperature setpoints in K #27

cprotopa opened this issue Apr 2, 2020 · 1 comment · Fixed by #28

Comments

@cprotopa
Copy link
Contributor

cprotopa commented Apr 2, 2020

In IDEAS, all temperatures are expressed in SI units, thus Kelvin. The implementation there also requires that the inputs for TSet be in K, as expressed in open-ideas/IDEAS#1127. Therefore I will propose to create a boolean parameter in StROBe that chooses to output TSet in C or K. The default would then be in K.
Anybody disagrees with this? @bramvdh91 @SilkeVerbruggen ?

@SilkeVerbruggen
Copy link
Contributor

I don't see any problem with that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants