Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add conditional connectors to StrobeInfoManager and update StROBe component #1125

Closed
jelgerjansen opened this issue Apr 1, 2020 · 0 comments · Fixed by #1127
Closed

add conditional connectors to StrobeInfoManager and update StROBe component #1125

jelgerjansen opened this issue Apr 1, 2020 · 0 comments · Fixed by #1127
Milestone
Release 2.2

Comments

@jelgerjansen
Copy link
Contributor

jelgerjansen commented Apr 1, 2020 •
edited
Loading

Conditional connectors should be added to the IDEAS.BoundaryConditions.Occupants.StrobeInfoManager component to be in line with the modelica specification.

The parameters IDEAS.BoundaryConditions.Occupants.StROBe component, which calls the StrobeInfoManager, also needs to be update. Furthermore, RealExpression TSet_signal is adapted as follows:
TSet_signal(y=TSet_internal+273.15*ones(nZones)),
since the temperature setpoints given by StROBe are expressed in degrees celcius.

I will make a pull request
jelgerjansen pushed a commit to jelgerjansen/IDEAS that referenced this issue Apr 1, 2020
Added conditional connectors to be in line with the Modelica specific…
1fd80a5 
…ation in StrobeInfoManager and updated the StROBe model for issue open-ideas#1125
@jelgerjansen jelgerjansen mentioned this issue Apr 1, 2020
Closed
jelgerjansen pushed a commit to jelgerjansen/IDEAS that referenced this issue Apr 1, 2020
Corrected documentation for issue open-ideas#1125
89ecefc
jelgerjansen pushed a commit to jelgerjansen/IDEAS that referenced this issue Apr 1, 2020
Corrected documentation for issue open-ideas#1125
11b8261
@Mathadon Mathadon mentioned this issue Apr 1, 2020
Merged
@Mathadon Mathadon added this to the Release 2.2 milestone Apr 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release 2.2
Development

Successfully merging a pull request may close this issue.

Issue1125 st ro be open-ideas/IDEAS
2 participants
@Mathadon @jelgerjansen