Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: Unit-test "Test_SUM_Queue" doesn't work #4185

Open
omordyk opened this issue Dec 5, 2024 · 0 comments · May be fixed by #4186
Open

Bug: Unit-test "Test_SUM_Queue" doesn't work #4185

omordyk opened this issue Dec 5, 2024 · 0 comments · May be fixed by #4186
Assignees
@omordyk
Labels
bug

Comments

@omordyk
Copy link

omordyk commented Dec 5, 2024 •
edited
Loading

Describe the bug.

Unit-tests fail:

# github.com/open-horizon/anax/agreementbot [github.com/open-horizon/anax/agreementbot.test]
agreementbot/secret_updater_test.go:32:9: not enough arguments in call to NewSecretUpdateManager

Describe the steps to reproduce the behavior.

Run make test :

Executing unit tests
# github.com/open-horizon/anax/agreementbot [github.com/open-horizon/anax/agreementbot.test]
agreementbot/secret_updater_test.go:32:9: not enough arguments in call to NewSecretUpdateManager
	have ()
	want (int, int, int, int)
	github.com/open-horizon/anax/abstractprotocol		coverage: 0.0% of statements
	github.com/open-horizon/anax		coverage: 0.0% of statements
FAIL	github.com/open-horizon/anax/agreementbot [build failed]
	github.com/open-horizon/anax/agreement		coverage: 0.0% of statements
	github.com/open-horizon/anax/agreementbot/persistence		coverage: 0.0% of statements
	github.com/open-horizon/anax/agreementbot/secrets		coverage: 0.0% of statements
	github.com/open-horizon/anax/agreementbot/persistence/bolt		coverage: 0.0% of statements
	github.com/open-horizon/anax/agreementbot/persistence/postgresql		coverage: 0.0% of statements
	github.com/open-horizon/anax/agreementbot/secrets/vault		coverage: 0.0% of statements

Expected behavior.

Unit-test passes

Screenshots.

Screenshot 2024-12-05 at 10 23 43

Operating Environment

Local build

Additional Information

No response
@omordyk omordyk added the bug label Dec 5, 2024
@omordyk omordyk self-assigned this Dec 5, 2024
@omordyk omordyk changed the title Bug: Unit-tests don't work Bug: Unit-test "Test_SUM_Queue" doesn't work Dec 5, 2024
@omordyk omordyk linked a pull request Dec 5, 2024 that will close this issue
Open
12 tasks
omordyk added a commit that referenced this issue Dec 5, 2024
@omordyk
Issue #4185 - Fix "Test_SUM_Queue" unit-test
1fc9532 
Signed-off-by: Oleksandr Mordyk <[email protected]>
omordyk added a commit that referenced this issue Dec 6, 2024
@omordyk
Issue #4185 - Fix "Test_SUM_Queue" unit-test
0800cc2 
Signed-off-by: Oleksandr Mordyk <[email protected]>
@omordyk omordyk linked a pull request Dec 16, 2024 that will close this issue
Fix "Test_SUM_Queue" unit-test #4186
Open
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@omordyk omordyk

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix "Test_SUM_Queue" unit-test open-horizon/anax
1 participant
@omordyk