Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add log entries for prefill plugins to submissions #4518

Open
LaurensBurger opened this issue Jul 11, 2024 · 4 comments
Open

Add log entries for prefill plugins to submissions #4518

LaurensBurger opened this issue Jul 11, 2024 · 4 comments
Assignees
Milestone

Comments

@LaurensBurger
Copy link
Collaborator

LaurensBurger commented Jul 11, 2024

Thema / Theme

Admin

Omschrijving / Description

When investigating something wrong/missing from a submission it would be nice to see the status of the prefill plugin results and if the cause of why i'm looking at the submission was in fact the prefill plugin failing to retrieve data.

Currently the prefill plugins are logged in the timeline log entries as:

[[2024-07-11 11:19:23 CEST] (Submission 123): Prefill plugin "StUF-BG" (stufbg) reported: Successfully retrieved information to prefill fields: BSN (bsn), Geslacht (geslachtsaanduiding), Straatnaam (straatnaam), Voornamen (voornamen), Huisnummer (huisnummer), Voorvoegsels (voorvoegselGeslachtsnaam), Huisletter (huisletter), Achternaam (geslachtsnaam), Toevoeging (huisnummertoevoeging), Postcode (postcode), Woonplaats (woonplaatsNaam), Geboortedatum (geboortedatum)]
or
[[2024-07-10 15:28:44 CEST] (Submission 123): Prefill plugin "KvK Bedrijf via KvK-nummer" (kvk-kvknumber) returned empty values]

if these were also visible in the submission log, it would save them a lot of time (since the log entries search is very slow and not very accurate)

Added value / Toegevoegde waarde

No response

Aanvullende opmerkingen / Additional context

No response

@LaurensBurger LaurensBurger added triage Issue needs to be validated. Remove this label if the issue considered valid. enhancement labels Jul 11, 2024
@joeribekker
Copy link
Contributor

Refinement: It might be related to excluded entries because of AVG. It might be just removing this exclude. Please check and report in this ticket what other entries will popup because of this.

@joeribekker joeribekker added this to the Release 2.8.0 milestone Jul 15, 2024
@joeribekker joeribekker removed the triage Issue needs to be validated. Remove this label if the issue considered valid. label Jul 15, 2024
@vaszig
Copy link
Contributor

vaszig commented Oct 3, 2024

Refinement: It might be related to excluded entries because of AVG. It might be just removing this exclude. Please check and report in this ticket what other entries will popup because of this.

This is happening on purpose since all the prefill log events are marked as TimelineLogTags.AVG. All this kind of tags are excluded from the SubmissionLogInline and this was done because of #943. Removing the exclude would mean that we show the prefill fields in the admin, but the following are affected as well:

  • outgoing_request_log_details_view_admin
  • submission_details_view_admin
  • submission_details_view_api
  • submission_export_list

@joeribekker what is your opinion?Do we want to revert this and remove the exclude?

@vaszig vaszig added the blocked label Oct 3, 2024
@joeribekker
Copy link
Contributor

Can we add a new tag "submission lifecycle" and just use this as filter on the submission page?

@sergei-maertens
Copy link
Member

Refinement:

  • Currently some log records are tagged as AVG/GDPR so they can be filtered
  • The submissions logs now exclude this tag
  • Tags are not meant to be used for excusion, rather inclusion
  • Add new tag for all lifecycle events and do an inclusion filter instead of the AVG exclusion
  • This means that an event can have multiple (decoupled) tags so they show up in different contexts

@sergei-maertens sergei-maertens removed their assignment Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Todo
Development

No branches or pull requests

4 participants