fix: Improve error handling in OpenFeatureClient #121
Conversation
|
The failures above I don't think are related to my commit above. Not sure how you'd like me to approach resolving that? |
|
@tcarrio do you know what |
|
I'll investigate the phpstan error In the meantime @schodemeiss could you add or update tests around this? I love the idea of including more exception context in the error. This is a good improvement overall 👍 |
|
For both PRs, your commits need to be signed off for the DCO. |
|
If you end up fixing the phpstan error yourself I'll definitely approve that to merge. I have a bigger PR coming down the pipeline that resolved this in #122. You could reference that if necessary. I'll fix in merge conflicts on my end if yours is ready first 😎 |
|
Rebasing now that main has your phpstan fixes |
The commit adds the flagKey to EvaluationDetailsBuilder during error handling, providing more context for debugging. It also includes error message within the ResolutionError for more complete error information. Signed-off-by: Andrew Menino-Barlow <[email protected]>
|
LGTM! Merging ✅ |
🤖 I have created a release *beep* *boop* --- ## [2.0.6](2.0.5...2.0.6) (2024-05-07) ### 🐛 Bug Fixes * Improve error handling in OpenFeatureClient ([#121](#121)) ([58e97d2](58e97d2)) * Use late static binding in AbstractProvider ([#123](#123)) ([2123274](2123274)) ### 🧹 Chore * **deps:** update dependency psalm/plugin-phpunit to ^0.19.0 ([#119](#119)) ([09f9d47](09f9d47)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This PR
The PR adds the
flagKeyto EvaluationDetailsBuilder during error handling, providing more context for debugging. It also includes error message within the ResolutionError for more complete error information.How to test
Modify the NoOpProvider to throw any exception with a message. This should then propergate through to this new error handling