fix: event-handler leakage #788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes an issue where event handlers could be leaked if the same handler reference was added twice to different events Signed-off-by: Todd Baert <[email protected]>
toddbaert
commented
Jan 25, 2024
toddbaert
requested review from
beeme1mr,
luizgribeiro,
thomaspoignant and
lukas-reining
Signed-off-by: Todd Baert <[email protected]>
beeme1mr
approved these changes
Jan 25, 2024
Signed-off-by: Todd Baert <[email protected]>
Signed-off-by: Todd Baert <[email protected]>
toddbaert
commented
Jan 25, 2024
lukas-reining
approved these changes
Jan 25, 2024
|
It occurred to me this fix is incomplete. It still possible to add the same handler to the same event twice and lose the first ref. I have another fix in mind. Marked as draft for now |
Signed-off-by: Todd Baert <[email protected]>
|
Hey @beeme1mr @lukas-reining please re-review. As mentioned here, we also need to support the addition and removal of duplicate handlers to the same event. This is done by making the weakmap values arrays, and appending/popping them (this is consistent with how nodes event handlers work). I've added this functionality, and 2 relevant tests. |
Signed-off-by: Todd Baert <[email protected]>
beeme1mr
approved these changes
Jan 26, 2024
lukas-reining
approved these changes
Jan 26, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 30, 2024
🤖 I have created a release *beep* *boop* --- ## [0.0.24](core-v0.0.23...core-v0.0.24) (2024-01-27) ### ✨ New Features * adds ErrorOptions to Error constructor ([#765](#765)) ([2f59a9f](2f59a9f)) ### 🐛 Bug Fixes * event-handler leakage ([#788](#788)) ([69c7f05](69c7f05)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Signed-off-by: OpenFeature Bot <[email protected]> Signed-off-by: openfeature-peer-update-bot <[email protected]> Co-authored-by: openfeature-peer-update-bot <[email protected]>
This was referenced Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue where event handlers could be leaked if the same handler reference was added multiple times.