Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: adds ErrorOptions to Error constructor #765

Merged
merged 3 commits into from
Jan 20, 2024
Merged

feat: adds ErrorOptions to Error constructor #765

merged 3 commits into from
Jan 20, 2024

Conversation

NeerajGartia21
Copy link
Contributor

This PR

  • adds ErrorOptions to Error constructor
  • updates compiler option to es2022

Related Issues

Fixes this

Notes

Follow-up Tasks

How to test

@NeerajGartia21 NeerajGartia21 requested a review from a team as a code owner January 15, 2024 19:04
beeme1mr
beeme1mr reviewed Jan 18, 2024
View reviewed changes
Copy link
Member

@beeme1mr beeme1mr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good to me but there are a few docs that should be updated prior to this PR being merged. Please change the compilation target to es2022.

FYI @toddbaert, we specified es2015 for the client SDK but we could update it to es2022 prior to a GA release.

@beeme1mr beeme1mr requested a review from toddbaert January 18, 2024 20:11
@NeerajGartia21
Copy link
Contributor Author

Thanks for the review. I've updated the compilation target to es2022 and also updated the docs accordingly.

lukas-reining
lukas-reining previously approved these changes Jan 18, 2024
View reviewed changes
Copy link
Member

@lukas-reining lukas-reining left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! I will have time to try to build it tomorrow.
Thanks for the PR! :)

@lukas-reining lukas-reining self-requested a review January 18, 2024 20:50
@lukas-reining lukas-reining dismissed their stale review January 18, 2024 20:51

Accidentally approved, I will approve after trying to build.

lukas-reining
lukas-reining approved these changes Jan 19, 2024
View reviewed changes
Copy link
Member

@lukas-reining lukas-reining left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Building works and the built SDK works in the playground, thanks!

@lukas-reining lukas-reining added this pull request to the merge queue Jan 20, 2024
Merged via the queue into open-feature:main with commit 2f59a9f Jan 20, 2024
7 checks passed
This was referenced Jan 20, 2024
Merged
Merged
Merged
Merged
Merged
@toddbaert
Copy link
Member

Thanks for reviewing guys! I've been heads-down working on the .NET release.

Thanks to you for this contribution @NeerajGartia21 !

@NeerajGartia21 NeerajGartia21 deleted the error-cause branch January 22, 2024 15:43
github-merge-queue bot pushed a commit that referenced this pull request Jan 30, 2024
@openfeaturebot
chore(main): release core 0.0.24 (#770)
12b3b35 
🤖 I have created a release *beep* *boop*
---


##
[0.0.24](core-v0.0.23...core-v0.0.24)
(2024-01-27)


### ✨ New Features

* adds ErrorOptions to Error constructor
([#765](#765))
([2f59a9f](2f59a9f))


### 🐛 Bug Fixes

* event-handler leakage
([#788](#788))
([69c7f05](69c7f05))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Signed-off-by: OpenFeature Bot <[email protected]>
Signed-off-by: openfeature-peer-update-bot <[email protected]>
Co-authored-by: openfeature-peer-update-bot <[email protected]>
toddbaert pushed a commit that referenced this pull request Jan 30, 2024
@openfeaturebot
chore(main): release web-sdk 0.4.11 (#769)
35a612c 
🤖 I have created a release *beep* *boop*
---


##
[0.4.11](web-sdk-v0.4.10...web-sdk-v0.4.11)
(2024-01-30)


### ✨ New Features

* adds ErrorOptions to Error constructor
([#765](#765))
([2f59a9f](2f59a9f))


### 🧹 Chore

* **main:** release core 0.0.24
([#770](#770))
([12b3b35](12b3b35))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Signed-off-by: OpenFeature Bot <[email protected]>
github-merge-queue bot pushed a commit that referenced this pull request Jan 30, 2024
@openfeaturebot @toddbaert
chore(main): release server-sdk 1.10.0 (#771)
4114e63 
🤖 I have created a release *beep* *boop*
---


##
[1.10.0](server-sdk-v1.9.1...server-sdk-v1.10.0)
(2024-01-30)


### ✨ New Features

* adds ErrorOptions to Error constructor
([#765](#765))
([2f59a9f](2f59a9f))


### 🧹 Chore

* **main:** release core 0.0.24
([#770](#770))
([12b3b35](12b3b35))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Signed-off-by: OpenFeature Bot <[email protected]>
Signed-off-by: Todd Baert <[email protected]>
Co-authored-by: Todd Baert <[email protected]>
github-merge-queue bot pushed a commit that referenced this pull request Jan 31, 2024
@openfeaturebot
chore(main): release nestjs-sdk 0.0.5-experimental (#772)
6f62eb2 
🤖 I have created a release *beep* *boop*
---


##
[0.0.5-experimental](nestjs-sdk-v0.0.4-experimental...nestjs-sdk-v0.0.5-experimental)
(2024-01-31)


### ✨ New Features

* adds ErrorOptions to Error constructor
([#765](#765))
([2f59a9f](2f59a9f))


### 🐛 Bug Fixes

* **nest:** add peer deps for nestjs-core and rxjs 9
([#784](#784))
([a452bdd](a452bdd))
* removed duped core types
([#800](#800))
([7cc1e09](7cc1e09))


### 📚 Documentation

* Nest SDK ([#750](#750))
([a21634d](a21634d))
* update nestjs readme examples
([#787](#787))
([c6a357a](c6a357a))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Signed-off-by: OpenFeature Bot <[email protected]>
toddbaert added a commit that referenced this pull request Feb 1, 2024
@openfeaturebot @toddbaert
chore(main): release react-sdk 0.1.1-experimental (#773)
732ea41 
🤖 I have created a release *beep* *boop*
---


##
[0.1.1-experimental](react-sdk-v0.1.0-experimental...react-sdk-v0.1.1-experimental)
(2024-01-31)


### ✨ New Features

* adds ErrorOptions to Error constructor
([#765](#765))
([2f59a9f](2f59a9f))


### 🐛 Bug Fixes

* removed duped core types
([#800](#800))
([7cc1e09](7cc1e09))


### 📚 Documentation

* update react readme
([#792](#792))
([1666597](1666597))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Signed-off-by: OpenFeature Bot <[email protected]>
Signed-off-by: Todd Baert <[email protected]>
Co-authored-by: Todd Baert <[email protected]>
@openfeaturebot openfeaturebot mentioned this pull request Mar 12, 2024
Closed
@openfeaturebot openfeaturebot mentioned this pull request Mar 12, 2024
Closed
@andreas-karlsson andreas-karlsson mentioned this pull request Jun 6, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukas-reining lukas-reining lukas-reining approved these changes

@beeme1mr beeme1mr beeme1mr approved these changes

@toddbaert toddbaert Awaiting requested review from toddbaert

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE] Add new constructors to the Error classes that support error options
4 participants
@NeerajGartia21 @toddbaert @beeme1mr @lukas-reining