fix: missing events bundled dep #660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toddbaert
force-pushed
the
fix/missing-events-bundled-dep
branch
from
afbd9ac to
1b26152
Compare
toddbaert
force-pushed
the
fix/missing-events-bundled-dep
branch
from
1b26152 to
337eefb
Compare
Signed-off-by: Todd Baert <[email protected]>
toddbaert
commented
Nov 8, 2023
toddbaert
commented
Nov 8, 2023
toddbaert
commented
Nov 8, 2023
Signed-off-by: Todd Baert <[email protected]>
Signed-off-by: Todd Baert <[email protected]>
|
@toddbaert This is awesome. Thank you so much for moving on this so quickly. We were doing some discovery work on available feature flagging tools for the web and this is at the top of our adoption list 😄 |
Thanks for finding the issue. FWIW, I think if you use the last published versions of |
beeme1mr
approved these changes
Nov 8, 2023
lukas-reining
approved these changes
Nov 9, 2023
This was referenced Nov 9, 2023
toddbaert
pushed a commit
that referenced
this pull request
Nov 9, 2023
🤖 I have created a release *beep* *boop* --- ## [0.0.18](core-v0.0.17...core-v0.0.18) (2023-11-09) ### 🐛 Bug Fixes * missing events bundled dep ([#660](#660)) ([f0e2aa6](f0e2aa6)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Signed-off-by: OpenFeature Bot <[email protected]> Signed-off-by: openfeature-peer-update-bot <[email protected]> Co-authored-by: openfeature-peer-update-bot <[email protected]>
toddbaert
pushed a commit
that referenced
this pull request
Nov 9, 2023
🤖 I have created a release *beep* *boop* --- ## [0.4.5](web-sdk-v0.4.4...web-sdk-v0.4.5) (2023-11-09) ### 🐛 Bug Fixes * missing events bundled dep ([#660](#660)) ([f0e2aa6](f0e2aa6)) ### 🧹 Chore * **main:** release core 0.0.18 ([#661](#661)) ([cf7bbf0](cf7bbf0)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Signed-off-by: OpenFeature Bot <[email protected]>
toddbaert
added a commit
that referenced
this pull request
Nov 9, 2023
🤖 I have created a release *beep* *boop* --- ## [1.7.2](server-sdk-v1.7.1...server-sdk-v1.7.2) (2023-11-09) ### 🐛 Bug Fixes * missing events bundled dep ([#660](#660)) ([f0e2aa6](f0e2aa6)) ### 🧹 Chore * **main:** release core 0.0.18 ([#661](#661)) ([cf7bbf0](cf7bbf0)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Signed-off-by: OpenFeature Bot <[email protected]> Signed-off-by: Todd Baert <[email protected]> Co-authored-by: Todd Baert <[email protected]>
This was referenced Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #659
This PR fixes an issue created with this change, which removed the
eventspolyfill package from@openfeature/corewhere is wasn't always needed (see that issue for details). The problem was that we still importedeventsin the@openfeature/coremodule, but can't use theeventsbundled in the@openfeature/web-sdksince the bundled package there isn't accessible from imports in@openfeature/core.This PR removes all imports of
eventsfrom@openfeature/core, and instead only imports types. Imports ofeventsonly now occur in the web-sdk (where it's bundled) and server-sdk (where it's made available by the node runtime), not in the common module.Unfortunately this issue was a bit tough to track down, because
eventsis VERY common, and lots of bundlers, etc will add it, so it's frequently available "accidentally".Thanks to @juanparadox for the report.