Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for clearing providers #578

Merged
merged 4 commits into from
Oct 13, 2023
Merged

feat: add support for clearing providers #578

merged 4 commits into from
Oct 13, 2023

Conversation

beeme1mr
Copy link
Member

@beeme1mr beeme1mr commented Oct 9, 2023

This PR

  • adds support for clearing providers

Related Issues

Fixes #526

Notes

We may want to consider adding a reset method that calls clearHooks, clearProviders, rests the logger, and clears event listeners. There are a few tests that use a hacky method to do this already.

@beeme1mr beeme1mr requested a review from a team as a code owner October 9, 2023 01:14
@beeme1mr beeme1mr requested review from lukas-reining, thomaspoignant and toddbaert and removed request for a team October 9, 2023 01:15
packages/client/src/open-feature.ts Outdated Show resolved Hide resolved
packages/client/test/client.spec.ts Show resolved Hide resolved
packages/shared/src/open-feature.ts Show resolved Hide resolved
Signed-off-by: Michael Beemer <[email protected]>
packages/client/src/open-feature.ts Outdated Show resolved Hide resolved
packages/server/src/open-feature.ts Outdated Show resolved Hide resolved
Signed-off-by: Michael Beemer <[email protected]>
@beeme1mr
Copy link
Member Author

@toddbaert @lukas-reining I've addressed the concerns you identified. Please take a look when you have a moment.

Copy link
Member

@lukas-reining lukas-reining left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! :)

@beeme1mr beeme1mr merged commit a3a907f into main Oct 13, 2023
@beeme1mr beeme1mr deleted the clear-provider branch October 13, 2023 14:18
toddbaert pushed a commit that referenced this pull request Oct 31, 2023
🤖 I have created a release *beep* *boop*
---


##
[0.0.13](shared-v0.0.12...shared-v0.0.13)
(2023-10-31)


### Features

* add support for clearing providers
([#578](#578))
([a3a907f](a3a907f))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Signed-off-by: OpenFeature Bot <[email protected]>
github-merge-queue bot pushed a commit that referenced this pull request Oct 31, 2023
🤖 I have created a release *beep* *boop*
---


##
[0.4.2](web-sdk-v0.4.1...web-sdk-v0.4.2)
(2023-10-31)


### Features

* add support for clearing providers
([#578](#578))
([a3a907f](a3a907f))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Signed-off-by: OpenFeature Bot <[email protected]>
github-merge-queue bot pushed a commit that referenced this pull request Oct 31, 2023
🤖 I have created a release *beep* *boop*
---


##
[0.0.14](core-v0.0.13...core-v0.0.14)
(2023-10-31)


### Features

* add support for clearing providers
([#578](#578))
([a3a907f](a3a907f))
* extract and publish core package
([#629](#629))
([c3ee90b](c3ee90b))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Signed-off-by: OpenFeature Bot <[email protected]>
Signed-off-by: openfeature-peer-update-bot <[email protected]>
Co-authored-by: openfeature-peer-update-bot <[email protected]>
github-merge-queue bot pushed a commit that referenced this pull request Oct 31, 2023
🤖 I have created a release *beep* *boop*
---


##
[1.7.0](server-sdk-v1.6.3...server-sdk-v1.7.0)
(2023-10-31)


### Features

* add support for clearing providers
([#578](#578))
([a3a907f](a3a907f))
* extract and publish core package
([#629](#629))
([c3ee90b](c3ee90b))


### Bug Fixes

* api docs links
([#645](#645))
([4ff3f0e](4ff3f0e))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Signed-off-by: OpenFeature Bot <[email protected]>
Signed-off-by: Todd Baert <[email protected]>
Co-authored-by: Todd Baert <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add utility function to clear providers for testing purposes
4 participants