-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for clearing providers #578
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Beemer <[email protected]>
beeme1mr
requested review from
lukas-reining,
thomaspoignant and
toddbaert
and removed request for
a team
October 9, 2023 01:15
beeme1mr
commented
Oct 9, 2023
Signed-off-by: Michael Beemer <[email protected]>
thomaspoignant
approved these changes
Oct 9, 2023
toddbaert
reviewed
Oct 9, 2023
Signed-off-by: Michael Beemer <[email protected]>
@toddbaert @lukas-reining I've addressed the concerns you identified. Please take a look when you have a moment. |
lukas-reining
approved these changes
Oct 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! :)
This was referenced Oct 13, 2023
This was referenced Oct 30, 2023
toddbaert
pushed a commit
that referenced
this pull request
Oct 31, 2023
🤖 I have created a release *beep* *boop* --- ## [0.0.13](shared-v0.0.12...shared-v0.0.13) (2023-10-31) ### Features * add support for clearing providers ([#578](#578)) ([a3a907f](a3a907f)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Signed-off-by: OpenFeature Bot <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 31, 2023
🤖 I have created a release *beep* *boop* --- ## [0.4.2](web-sdk-v0.4.1...web-sdk-v0.4.2) (2023-10-31) ### Features * add support for clearing providers ([#578](#578)) ([a3a907f](a3a907f)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Signed-off-by: OpenFeature Bot <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 31, 2023
🤖 I have created a release *beep* *boop* --- ## [0.0.14](core-v0.0.13...core-v0.0.14) (2023-10-31) ### Features * add support for clearing providers ([#578](#578)) ([a3a907f](a3a907f)) * extract and publish core package ([#629](#629)) ([c3ee90b](c3ee90b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Signed-off-by: OpenFeature Bot <[email protected]> Signed-off-by: openfeature-peer-update-bot <[email protected]> Co-authored-by: openfeature-peer-update-bot <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 31, 2023
🤖 I have created a release *beep* *boop* --- ## [1.7.0](server-sdk-v1.6.3...server-sdk-v1.7.0) (2023-10-31) ### Features * add support for clearing providers ([#578](#578)) ([a3a907f](a3a907f)) * extract and publish core package ([#629](#629)) ([c3ee90b](c3ee90b)) ### Bug Fixes * api docs links ([#645](#645)) ([4ff3f0e](4ff3f0e)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Signed-off-by: OpenFeature Bot <[email protected]> Signed-off-by: Todd Baert <[email protected]> Co-authored-by: Todd Baert <[email protected]>
This was referenced Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Related Issues
Fixes #526
Notes
We may want to consider adding a reset method that calls
clearHooks
,clearProviders
, rests the logger, and clears event listeners. There are a few tests that use a hacky method to do this already.