Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: implement events and shutdown for spec 0.6.0 #422

Merged
merged 8 commits into from
Jun 27, 2023
Merged

feat!: implement events and shutdown for spec 0.6.0 #422

merged 8 commits into from
Jun 27, 2023

Conversation

lukas-reining
Copy link
Member

This PR

Implements events and shutdown from open-feature/js-sdk#424.

Related Issues

Fixes #421

Notes

Follow-up Tasks

How to test

@lukas-reining lukas-reining requested a review from a team as a code owner June 20, 2023 09:47
@lukas-reining lukas-reining self-assigned this Jun 20, 2023
beeme1mr
beeme1mr reviewed Jun 20, 2023
View reviewed changes
Copy link
Member

@beeme1mr beeme1mr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, it looks good. Just added a few comments.

libs/providers/config-cat/README.md Show resolved Hide resolved
libs/providers/config-cat/src/lib/config-cat-provider.ts Outdated Show resolved Hide resolved
@beeme1mr beeme1mr requested a review from toddbaert June 20, 2023 12:27
@toddbaert
Copy link
Member

@lukas-reining I'll leave it up to you, since you're the owner of this provider, but I think I would consider marking this as a breaking change for your provider, because it requires 1.3.0 and won't work properly without it. I expect providers to have breaking changes fairly often, and usually they should be easy to absorb since it's just usually some configuration code or deps that need updating.

You can mark this breaking by changing the PR title to feat!: implement events and shutdown for spec 0.6.0 (note the !)

@toddbaert toddbaert self-requested a review June 26, 2023 19:25
odubajDT
odubajDT approved these changes Jun 27, 2023
View reviewed changes
Copy link
Contributor

@odubajDT odubajDT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not a JS/TS expert, but LGTM :)

@lukas-reining lukas-reining changed the title feat: implement events and shutdown for spec 0.6.0 feat!: implement events and shutdown for spec 0.6.0 Jun 27, 2023
@lukas-reining lukas-reining merged commit 3db6927 into open-feature:main Jun 27, 2023
@lukas-reining lukas-reining deleted the feat/configcat-0.6.0 branch June 27, 2023 12:05
@github-actions github-actions bot mentioned this pull request Jun 27, 2023
Merged
@lukas-reining lukas-reining mentioned this pull request Jun 29, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@odubajDT odubajDT odubajDT approved these changes

@toddbaert toddbaert toddbaert approved these changes

@beeme1mr beeme1mr beeme1mr approved these changes

Assignees

@lukas-reining lukas-reining

Labels
v0.6.0-support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[configcat-provider] add spec 0.6.0 support
4 participants
@lukas-reining @toddbaert @beeme1mr @odubajDT