-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: shutdown method blocks until task executor shutdown completes #873
fix: shutdown method blocks until task executor shutdown completes #873
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #873 +/- ##
============================================
- Coverage 95.41% 95.21% -0.21%
- Complexity 383 384 +1
============================================
Files 36 36
Lines 873 877 +4
Branches 52 53 +1
============================================
+ Hits 833 835 +2
- Misses 21 23 +2
Partials 19 19
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: jarebudev <[email protected]>
Signed-off-by: jarebudev <[email protected]>
c3722cd
to
b9e1ca6
Compare
Looks good, thanks @jarebudev. I'll leave this open for comment until tomorrow. |
Quality Gate passedIssues Measures |
This PR
is to ensure the shutdown method waits until the task executor (which is a daemon thread) has either completed shutdown or the timeout period elapses.
Related Issues
Fixes #683
Notes
I set the period to wait for completion to 3 seconds
Follow-up Tasks
n/a
How to test
n/a