Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: shutdown method blocks until task executor shutdown completes #873

Merged

Conversation

jarebudev
Copy link
Contributor

This PR

is to ensure the shutdown method waits until the task executor (which is a daemon thread) has either completed shutdown or the timeout period elapses.

Related Issues

Fixes #683

Notes

I set the period to wait for completion to 3 seconds

Follow-up Tasks

n/a

How to test

n/a

@jarebudev jarebudev requested a review from a team as a code owner March 28, 2024 23:30
@jarebudev jarebudev changed the title shutdown method blocks until task executor shutdown completes fix: shutdown method blocks until task executor shutdown completes Mar 28, 2024
Copy link

codecov bot commented Mar 28, 2024

Codecov Report

Attention: Patch coverage is 14.28571% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 95.21%. Comparing base (dd671ad) to head (48a89fd).

Files Patch % Lines
...rc/main/java/dev/openfeature/sdk/EventSupport.java 14.28% 5 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #873      +/-   ##
============================================
- Coverage     95.41%   95.21%   -0.21%     
- Complexity      383      384       +1     
============================================
  Files            36       36              
  Lines           873      877       +4     
  Branches         52       53       +1     
============================================
+ Hits            833      835       +2     
- Misses           21       23       +2     
  Partials         19       19              
Flag Coverage Δ
unittests 95.21% <14.28%> (-0.21%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Kavindu-Dodan Kavindu-Dodan force-pushed the feat/683_shutdown_doesnt_block branch from c3722cd to b9e1ca6 Compare April 2, 2024 21:52
@Kavindu-Dodan Kavindu-Dodan requested a review from toddbaert April 2, 2024 21:56
@beeme1mr
Copy link
Member

beeme1mr commented Apr 2, 2024

Looks good, thanks @jarebudev. I'll leave this open for comment until tomorrow.

Copy link

sonarqubecloud bot commented Apr 5, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@beeme1mr beeme1mr merged commit 8dec14f into open-feature:main Apr 6, 2024
6 of 8 checks passed
@jarebudev jarebudev deleted the feat/683_shutdown_doesnt_block branch May 22, 2024 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shutdown doesn't block
4 participants