Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maven dependency for Jakarta and Java 17 #867

Closed
Exnadella opened this issue Mar 25, 2024 · 5 comments · Fixed by #921
Closed

Maven dependency for Jakarta and Java 17 #867

Exnadella opened this issue Mar 25, 2024 · 5 comments · Fixed by #921
Assignees

Comments

@Exnadella
Copy link

Dear Team,

We're requesting the release of the dependency for Jakarta and Java 17, as we're transitioning most of our stack from Java 8 to Java 17, which necessitates migrating from Javax to Jakarta for compatibility. Additionally, could we consider using Spring Boot 3.2.0 for demonstration purposes?

@Kavindu-Dodan
Copy link
Contributor

@Exnadella thank you for raising concern over the Javax annotation. I can confirm that OpenFeature Java SDK uses javax.annotation.Nullable.

Could you please share any issues that you faced during the migration to Java 17 ? For example, do you have checks for Javax ? Otherwise, if you intend to avoid dependency on jsr305, then you may do this by adding an exclusion rule to OF Java SDK.

For example, for maven

        <dependency>
            <groupId>dev.openfeature</groupId>
            <artifactId>sdk</artifactId>
            <version>1.7.6</version>
            <exclusions>
                <exclusion>
                    <groupId>com.google.code.findbugs</groupId>
                    <artifactId>jsr305</artifactId>
                </exclusion>
            </exclusions>
        </dependency>

A missing annotation should not fail your build or application.

@toddbaert
Copy link
Member

toddbaert commented May 3, 2024

I think we should remove all @Nullable usage from the SDK. It's not doing that much for us, I don't think it's worth the trouble since it's non-standard.

@Kavindu-Dodan
Copy link
Contributor

@toddbaert yeah, that's an option and a quick solution for this

@toddbaert
Copy link
Member

@DBlanchard88 is working on this.

@toddbaert
Copy link
Member

@Exnadella We have removed all these annotations. The next release will not contain them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants