fix: support immutable maps #859 #860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ARobertsCollibra
force-pushed
the
issue/859
branch
from
14238ee to
578877e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #860 +/- ##
============================================
+ Coverage 95.28% 95.53% +0.25%
- Complexity 370 371 +1
============================================
Files 34 34
Lines 849 852 +3
Branches 52 52
============================================
+ Hits 809 814 +5
+ Misses 21 20 -1
+ Partials 19 18 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ARobertsCollibra
force-pushed
the
issue/859
branch
from
578877e to
27a1d7f
Compare
toddbaert
requested review from
justinabrahms,
thisthat,
thiyagu06,
Kavindu-Dodan and
toddbaert
toddbaert
approved these changes
Mar 22, 2024
There was a problem hiding this comment.
Very nice catch @ARobertsCollibra !
Thanks for adding the tests as well.
|
Hey @ARobertsCollibra I resolved a conflict with a PR in the same area, hope you don't mind. |
Signed-off-by: Adam Roberts <[email protected]>
…s by copying the passed in attributes Signed-off-by: Adam Roberts <[email protected]>
Kavindu-Dodan
force-pushed
the
issue/859
branch
from
500a688 to
3683197
Compare
|
Kavindu-Dodan
approved these changes
Mar 22, 2024
|
Thank you @ARobertsCollibra for the improvement |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Related Issues
Fixes #859