Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update readme for events #507

Merged
merged 4 commits into from
Jul 13, 2023
Merged

chore: update readme for events #507

merged 4 commits into from
Jul 13, 2023

Conversation

toddbaert
Copy link
Member

see title.

@toddbaert toddbaert requested a review from a team as a code owner July 13, 2023 18:37
@codecov
Copy link

codecov bot commented Jul 13, 2023

Codecov Report

Merging #507 (13bfdab) into main (40d1f0a) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main     #507   +/-   ##
=========================================
  Coverage     95.23%   95.23%           
  Complexity      329      329           
=========================================
  Files            31       31           
  Lines           755      755           
  Branches         37       37           
=========================================
  Hits            719      719           
  Misses           19       19           
  Partials         17       17           
Flag Coverage Δ
unittests 95.23% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@beeme1mr beeme1mr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add docs for named clients, init, and shutdown. You can use the JS docs as a reference.

https://github.com/open-feature/js-sdk/blob/main/packages/server/README.md#named-clients

Bump the badge version.

Signed-off-by: Todd Baert <[email protected]>
Signed-off-by: Todd Baert <[email protected]>
@toddbaert
Copy link
Member Author

Please add docs for named clients, init, and shutdown. You can use the JS docs as a reference.

https://github.com/open-feature/js-sdk/blob/main/packages/server/README.md#named-clients

Bump the badge version.

All done, except init. Init really is covered by events.

Signed-off-by: Todd Baert <[email protected]>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@toddbaert
Copy link
Member Author

Forcing this, just a README change and it matches the template.

@toddbaert toddbaert merged commit c115e96 into main Jul 13, 2023
@toddbaert toddbaert deleted the chore/update-readme-events branch July 13, 2023 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants