Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: validate list content to be values #350

Merged

Conversation

Kavindu-Dodan
Copy link
Contributor

@Kavindu-Dodan Kavindu-Dodan commented Mar 21, 2023

This PR

Fixes #286

Value.isList() now validate list internal objects to be Value typed

Signed-off-by: Kavindu Dodanduwa <[email protected]>
@github-advanced-security
Copy link

You have successfully added a new CodeQL configuration .github/workflows/pullrequest.yml:build. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.

@codecov
Copy link

codecov bot commented Mar 21, 2023

Codecov Report

Merging #350 (d4e20ba) into main (aec31b1) will increase coverage by 0.12%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main     #350      +/-   ##
============================================
+ Coverage     91.41%   91.53%   +0.12%     
- Complexity      212      213       +1     
============================================
  Files            23       23              
  Lines           489      496       +7     
  Branches         31       32       +1     
============================================
+ Hits            447      454       +7     
  Misses           24       24              
  Partials         18       18              
Flag Coverage Δ
unittests 91.53% <100.00%> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/main/java/dev/openfeature/sdk/Value.java 92.04% <100.00%> (+0.68%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@justinabrahms justinabrahms enabled auto-merge (squash) March 22, 2023 16:43
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@justinabrahms justinabrahms merged commit d8e7d9e into open-feature:main Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Value.isList accepts List<Object> where only the first element is a Value
3 participants