fix: handling of double and integer #316

apulbere · 2023-03-07T12:40:22Z

This PR

stores Number instead of Double
removes custom conversion from double to int and relies instead on API that respects Java Specs https://docs.oracle.com/javase/specs/jls/se7/html/jls-5.html#jls-5.1.3

Notes

This is a proposal

beeme1mr · 2023-03-07T13:27:10Z

Hey @apulbere, thanks for the PR. Someone will review it shortly.

codecov · 2023-03-07T15:46:20Z

Codecov Report

Merging #316 (f4841b1) into main (09824e7) will decrease coverage by 0.40%.
The diff coverage is 69.23%.

@@             Coverage Diff              @@
##               main     #316      +/-   ##
============================================
- Coverage     91.80%   91.41%   -0.40%     
+ Complexity      213      212       -1     
============================================
  Files            23       23              
  Lines           488      489       +1     
  Branches         31       31              
============================================
- Hits            448      447       -1     
  Misses           24       24              
- Partials         16       18       +2

Flag	Coverage Δ
unittests	`91.41% <69.23%> (-0.40%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
src/main/java/dev/openfeature/sdk/Structure.java	`87.50% <66.66%> (-2.25%)`	⬇️
src/main/java/dev/openfeature/sdk/Value.java	`91.35% <71.42%> (-1.24%)`	⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

toddbaert · 2023-03-07T16:50:48Z

src/test/java/dev/openfeature/sdk/ValueTest.java

        Value doubleValue = new Value(innerDoubleValue);
        assertTrue(doubleValue.isNumber());
-        assertEquals(1, doubleValue.asInteger());     // should be rounded
-        assertEquals(.75, doubleValue.asDouble());
+        assertEquals(1, doubleValue.asInteger());     // the double value represented by this object converted to type int
