Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(deps): Spot bug scope change #173

Merged
merged 64 commits into from
Nov 4, 2022
Merged

fix(deps): Spot bug scope change #173

merged 64 commits into from
Nov 4, 2022

Conversation

pbhandari9541
Copy link
Contributor

@pbhandari9541 pbhandari9541 commented Nov 3, 2022 •
edited
Loading

This PR

  • Adds provided scope for spot bugs dependency.

Related Issues

Fixes version conflict issue for spot-bug.

Notes

Follow-up Tasks

How to test

@pbhandari9541 pbhandari9541 changed the title Spot bug scope change fix(deps): Spot bug scope change Nov 3, 2022
toddbaert and others added 29 commits November 3, 2022 16:22
@toddbaert
chore: add integration tests (open-feature#77)
00dcafd 
* chore: add integration tests

Signed-off-by: Todd Baert <[email protected]>

* improve POM spacing

Signed-off-by: Todd Baert <[email protected]>

Signed-off-by: Todd Baert <[email protected]>
Signed-off-by: Bhandari, Pramesh(AWF) <[email protected]>
@github-actions
chore(main): release dev.openfeature.javasdk 0.2.2 (open-feature#76)
37e7670 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: Bhandari, Pramesh(AWF) <[email protected]>
@toddbaert
feat!: errorCode as enum, reason as string (open-feature#80)
82fe2e5 
* feat!: errorCode as enum, reason as string

- makes errorCode an enum
- makes reason a string
- adds errorMessage to resolution/evaluation details

Signed-off-by: Bhandari, Pramesh(AWF) <[email protected]>
@justinabrahms
chore: add CODEOWNERS (open-feature#85)
fe9f22b 
Create CODEOWNERS

refs open-feature#83

Signed-off-by: Justin Abrahms <[email protected]>

Signed-off-by: Justin Abrahms <[email protected]>
Signed-off-by: Bhandari, Pramesh(AWF) <[email protected]>
@renovate
chore: Configure Renovate (open-feature#86)
ec80de9 
chore(deps): add renovate.json

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: Bhandari, Pramesh(AWF) <[email protected]>
@renovate
chore(deps): update dependency com.github.spotbugs:spotbugs to v4.7.2 (…
982ca5f 
…open-feature#87)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: Bhandari, Pramesh(AWF) <[email protected]>
@renovate
chore(deps): update dependency com.github.spotbugs:spotbugs-maven-plu…
8f0ffe5 
…gin to v4.7.2.0 (open-feature#88)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: Bhandari, Pramesh(AWF) <[email protected]>
@renovate
chore(deps): update dependency org.apache.maven.plugins:maven-javadoc…
98fd932 
…-plugin to v3.4.1 (open-feature#90)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: Bhandari, Pramesh(AWF) <[email protected]>
@renovate
chore(deps): update dependency org.sonatype.plugins:nexus-staging-mav…
b2c7e21 
…en-plugin to v1.6.13 (open-feature#91)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: Bhandari, Pramesh(AWF) <[email protected]>
@renovate
fix(deps): update junit5 monorepo (open-feature#92)
9aa8213 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: Bhandari, Pramesh(AWF) <[email protected]>
@renovate
chore(deps): update dependency org.apache.maven.plugins:maven-pmd-plu…
4e0e376 
…gin to v3.19.0 (open-feature#97)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: Bhandari, Pramesh(AWF) <[email protected]>
@renovate
fix(deps): update dependency io.cucumber:cucumber-bom to v7.8.0 (open…
c06bae2 
…-feature#100)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: Bhandari, Pramesh(AWF) <[email protected]>
@renovate
chore(deps): update dependency org.mockito:mockito-core to v4.8.0 (op…
df24b82 
…en-feature#99)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: Bhandari, Pramesh(AWF) <[email protected]>
@renovate
chore(deps): update codecov/codecov-action action to v3 (open-feature…
d6851a7 
…#102)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: Bhandari, Pramesh(AWF) <[email protected]>
@renovate @justinabrahms
chore(deps): update dependency org.apache.maven.plugins:maven-gpg-plu…
7a69afa 
…gin to v1.6 (open-feature#96)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Justin Abrahms <[email protected]>
Signed-off-by: Bhandari, Pramesh(AWF) <[email protected]>
@renovate
chore(deps): update dependency org.apache.maven.plugins:maven-source-…
c06ba6a 
…plugin to v3 (open-feature#105)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: Bhandari, Pramesh(AWF) <[email protected]>
@renovate
chore(deps): update dependency org.apache.maven.plugins:maven-compile…
e1fb35e 
…r-plugin to v3.10.1 (open-feature#95)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: Bhandari, Pramesh(AWF) <[email protected]>
@renovate
chore(deps): update dependency org.apache.maven.plugins:maven-gpg-plu…
d03aae8 
…gin to v3 (open-feature#104)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: Bhandari, Pramesh(AWF) <[email protected]>
@renovate
chore(deps): update dependency org.apache.maven.plugins:maven-checkst…
8119817 
…yle-plugin to v3.2.0 (open-feature#94)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: Bhandari, Pramesh(AWF) <[email protected]>
@renovate
chore(deps): update actions/cache action to v3 (open-feature#101)
02e2e51 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: Bhandari, Pramesh(AWF) <[email protected]>
@renovate @justinabrahms
chore(deps): update dependency com.puppycrawl.tools:checkstyle to v8.…
a7acae2 
…45.1 (open-feature#93)

* chore(deps): update dependency com.puppycrawl.tools:checkstyle to v8.45.1

* scope property went away in the latest version

jshiell/checkstyle-idea#525 (comment)

Signed-off-by: Justin Abrahms <[email protected]>

* scope wasn't deleted on the other one

Signed-off-by: Justin Abrahms <[email protected]>

Signed-off-by: Justin Abrahms <[email protected]>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Justin Abrahms <[email protected]>
Signed-off-by: Bhandari, Pramesh(AWF) <[email protected]>
@justinabrahms @toddbaert
refactor!: Change the package name. Everyone knows it's java (or it d…
f177f92 
…oesn't matter) (open-feature#111)

* Change the package name. Everyone knows it's java (or it doesn't matter)

Fixes open-feature#82

Signed-off-by: Justin Abrahms <[email protected]>

* Missed 2 strings

Signed-off-by: Justin Abrahms <[email protected]>

* remove broken flagd import until changes absorbed

Signed-off-by: Todd Baert <[email protected]>

Signed-off-by: Justin Abrahms <[email protected]>
Signed-off-by: Todd Baert <[email protected]>
Co-authored-by: Todd Baert <[email protected]>
Signed-off-by: Bhandari, Pramesh(AWF) <[email protected]>
@justinabrahms
chore: Write perms should be as tightly scoped as possible. (open-fea…
ed91c56 
…ture#107)

* Add a dependabot file to keep deps up to date

Signed-off-by: Justin Abrahms <[email protected]>

* Move write permissions to the specific job, rather than globally

Signed-off-by: Justin Abrahms <[email protected]>

* Run code scanning (slow auto-build) weekly

Signed-off-by: Justin Abrahms <[email protected]>

Signed-off-by: Justin Abrahms <[email protected]>
Signed-off-by: Bhandari, Pramesh(AWF) <[email protected]>
@toddbaert
chore: fix dependabot pr titles (open-feature#118)
ce423db 
Signed-off-by: Todd Baert <[email protected]>

Signed-off-by: Todd Baert <[email protected]>
Signed-off-by: Bhandari, Pramesh(AWF) <[email protected]>
@dependabot
chore: Bump cucumber-bom from 7.8.0 to 7.8.1 (open-feature#115)
4795ea0 
Bump cucumber-bom from 7.8.0 to 7.8.1

Bumps [cucumber-bom](https://github.com/cucumber/cucumber-jvm) from 7.8.0 to 7.8.1.
- [Release notes](https://github.com/cucumber/cucumber-jvm/releases)
- [Changelog](https://github.com/cucumber/cucumber-jvm/blob/main/CHANGELOG.md)
- [Commits](cucumber/cucumber-jvm@v7.8.0...v7.8.1)

---
updated-dependencies:
- dependency-name: io.cucumber:cucumber-bom
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Bhandari, Pramesh(AWF) <[email protected]>
@justinabrahms
chore: add SAST scanning (open-feature#108)
d779757 
* add SAST scanning

Refs open-feature#84

Signed-off-by: Justin Abrahms <[email protected]>

* Java scanning only

Signed-off-by: Justin Abrahms <[email protected]>

* Try codeql on the normal build to see how much longer it is.

Signed-off-by: Justin Abrahms <[email protected]>

Signed-off-by: Justin Abrahms <[email protected]>
Signed-off-by: Bhandari, Pramesh(AWF) <[email protected]>
@toddbaert @justinabrahms
feat!: use evaluation context interface (open-feature#112)
9cf1e25 
* POC - use evaluation context interface

Signed-off-by: Todd Baert <[email protected]>

* make .merge non-static

Signed-off-by: Todd Baert <[email protected]>

* improve naming

Signed-off-by: Todd Baert <[email protected]>

* add @OverRide

Signed-off-by: Todd Baert <[email protected]>

* Update src/main/java/dev/openfeature/sdk/EvaluationContext.java

Co-authored-by: Justin Abrahms <[email protected]>
Signed-off-by: Todd Baert <[email protected]>

* Update src/main/java/dev/openfeature/sdk/MutableContext.java

Co-authored-by: Justin Abrahms <[email protected]>
Signed-off-by: Todd Baert <[email protected]>

* address PR feedback

Signed-off-by: Todd Baert <[email protected]>

Signed-off-by: Todd Baert <[email protected]>
Co-authored-by: Justin Abrahms <[email protected]>
Signed-off-by: Bhandari, Pramesh(AWF) <[email protected]>
@justinabrahms
feat: Support for generating CycloneDX sboms (open-feature#119)
4d46293 
Signed-off-by: Justin Abrahms <[email protected]>
Signed-off-by: Bhandari, Pramesh(AWF) <[email protected]>
@step-security-bot
chore: [StepSecurity] ci: Harden GitHub Actions (open-feature#120)
1ab5ef1 
* [StepSecurity] ci: Harden GitHub Actions in release.yml

* [StepSecurity] ci: Harden GitHub Actions in static-code-scanning.yaml

* [StepSecurity] ci: Harden GitHub Actions in lint-pr.yml

* [StepSecurity] ci: Harden GitHub Actions in merge.yml

* [StepSecurity] ci: Harden GitHub Actions in pullrequest.yml

Signed-off-by: Bhandari, Pramesh(AWF) <[email protected]>
toddbaert and others added 21 commits November 3, 2022 16:22
@toddbaert
feat!: add rw locks to client/api, hook accessor name (open-feature#131)
ae140c7 
* fix: add read/write locks to client/api

Signed-off-by: Todd Baert <[email protected]>

* dont lock entire evaluation

Signed-off-by: Todd Baert <[email protected]>

* add tests

Signed-off-by: Todd Baert <[email protected]>

* fixup comment

Signed-off-by: Todd Baert <[email protected]>

* fixup pom comment

Signed-off-by: Todd Baert <[email protected]>

* increase lock granularity, imporove tests

Signed-off-by: Todd Baert <[email protected]>

* fix spotbugs

Signed-off-by: Todd Baert <[email protected]>

* remove commented test

Signed-off-by: Todd Baert <[email protected]>

Signed-off-by: Todd Baert <[email protected]>
Signed-off-by: Bhandari, Pramesh(AWF) <[email protected]>
@renovate
chore(deps): update actions/setup-java digest to 3617c43 (open-featur…
3bf31ed 
…e#132)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: Bhandari, Pramesh(AWF) <[email protected]>
@renovate @justinabrahms
chore(deps): update amannn/action-semantic-pull-request digest to b31…
4750fb0 
…4c1b (open-feature#135)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Justin Abrahms <[email protected]>
Signed-off-by: Bhandari, Pramesh(AWF) <[email protected]>
@justinabrahms
chore: Remove dependabot. I like renovate better (open-feature#142)
5be7507 
Signed-off-by: Bhandari, Pramesh(AWF) <[email protected]>
@renovate
chore(deps): update amannn/action-semantic-pull-request digest to 7c1…
a900e9a 
…94c2 (open-feature#144)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: Bhandari, Pramesh(AWF) <[email protected]>
@renovate
chore(deps): update github/codeql-action digest to 44edb7c (open-feat…
ae4b242 
…ure#133)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: Bhandari, Pramesh(AWF) <[email protected]>
@renovate
chore(deps): update actions/checkout digest to 8230315 (open-feature#122
4e7fa02 
)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: Bhandari, Pramesh(AWF) <[email protected]>
@github-actions @justinabrahms
chore(main): release 0.3.0 (open-feature#114)
2ba2c5a 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Justin Abrahms <[email protected]>
Signed-off-by: Bhandari, Pramesh(AWF) <[email protected]>
@toddbaert
chore: re-enable integration tests (open-feature#146)
c24bfb4 
Update test harness and re-enable integration test profile

Signed-off-by: Bhandari, Pramesh(AWF) <[email protected]>
@renovate @justinabrahms
chore(deps): update actions/cache digest to 9b0c1fc (open-feature#145)
bdb0e09 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Justin Abrahms <[email protected]>
Signed-off-by: Bhandari, Pramesh(AWF) <[email protected]>
@rgrassian-split
fix: merge eval context (open-feature#149)
5c31280 
fix merge eval context

Signed-off-by: Robert Grassian <[email protected]>

Signed-off-by: Robert Grassian <[email protected]>
Signed-off-by: Bhandari, Pramesh(AWF) <[email protected]>
@github-actions
chore(main): release 0.3.1 (open-feature#150)
da01751 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: Bhandari, Pramesh(AWF) <[email protected]>
@renovate
chore(deps): update github/codeql-action digest to 297ec80 (open-feat…
79f92be 
…ure#147)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: Bhandari, Pramesh(AWF) <[email protected]>
@toddbaert
chore: update test/spec association numbers, badge (open-feature#156)
6392d07 
* chore: update test/spec association numbers

Signed-off-by: Todd Baert <[email protected]>

* chore: update spec tag

Signed-off-by: Todd Baert <[email protected]>

Signed-off-by: Todd Baert <[email protected]>
Signed-off-by: Bhandari, Pramesh(AWF) <[email protected]>
@renovate
chore(deps): update actions/cache digest to 2b04a41 (open-feature#158)
10dff7e 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: Bhandari, Pramesh(AWF) <[email protected]>
@beeme1mr @snyk-bot
chore(security): [Snyk] Security upgrade com.github.spotbugs:spotbugs…
1b2f4d9 
… from 4.7.2 to 4.7.3 (open-feature#157)

fix: pom.xml to reduce vulnerabilities

The following vulnerabilities are fixed with an upgrade:
- https://snyk.io/vuln/SNYK-JAVA-ORGAPACHECOMMONS-3043138

Co-authored-by: snyk-bot <[email protected]>
Signed-off-by: Bhandari, Pramesh(AWF) <[email protected]>
@toddbaert
chore: Add docs link (open-feature#165)
09dd513 
Signed-off-by: Todd Baert <[email protected]>

Signed-off-by: Todd Baert <[email protected]>
Signed-off-by: Bhandari, Pramesh(AWF) <[email protected]>
@justinabrahms
chore: Mark project as active. (open-feature#167)
e8317a4 
Mark project as active.

Signed-off-by: Justin Abrahms <[email protected]>

Signed-off-by: Justin Abrahms <[email protected]>
Signed-off-by: Bhandari, Pramesh(AWF) <[email protected]>
@github-actions
chore(main): release 1.0.0 (open-feature#168)
b7f847f 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: Bhandari, Pramesh(AWF) <[email protected]>
@renovate
chore(deps): update actions/cache digest to 8bec1e4 (open-feature#159)
0d91668 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: Bhandari, Pramesh(AWF) <[email protected]>
changes spotbug scope to provided.
83860cb 
Signed-off-by: Bhandari, Pramesh(AWF) <[email protected]>
@codecov-commenter
Copy link

Codecov Report

Merging #173 (92d3a6c) into main (2761e66) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main     #173   +/-   ##
=========================================
  Coverage     91.60%   91.60%           
  Complexity      187      187           
=========================================
  Files            20       20           
  Lines           417      417           
  Branches         22       22           
=========================================
  Hits            382      382           
  Misses           23       23           
  Partials         12       12
Flag Coverage Δ
unittests 91.60% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@justinabrahms justinabrahms merged commit 113b5e5 into open-feature:main Nov 4, 2022
@github-actions github-actions bot mentioned this pull request Nov 4, 2022
Merged
@pbhandari9541 pbhandari9541 mentioned this pull request Dec 7, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinabrahms justinabrahms justinabrahms approved these changes

@toddbaert toddbaert Awaiting requested review from toddbaert

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@pbhandari9541 @codecov-commenter @justinabrahms @toddbaert @step-security-bot @beeme1mr @rgrassian-split