Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate pkg path in flagd module #595

Open
bluebrown opened this issue Nov 5, 2024 · 1 comment
Open

deprecate pkg path in flagd module #595

bluebrown opened this issue Nov 5, 2024 · 1 comment

Comments

@bluebrown
Copy link

Hi, I am experimenting with this library and open feature sdk itself.
I feel like the import path is a bit awkward to use. I can see the pkg
path has been deprecated in the SDK already, but in this package not.

I have to import it like this. Which isn't nice, imo. And its also fiddley
to find out. You have to go and read the files and packages named to
understand that there is some naming inception going on.

import (
	flagd "github.com/open-feature/go-sdk-contrib/providers/flagd/pkg"
)

Perhaps this should just be github.com/open-feature/go-sdk-contrib/providers/flagd.
And then use internal directories to define the public API boundaries,
instead of pkg.

@bluebrown bluebrown changed the title deprecate pkg path deprecate pkg path in flagd module Nov 5, 2024
@toddbaert
Copy link
Member

toddbaert commented Nov 5, 2024

Ya I agree. We don't even need to support the old one, since the provider is not 1.0+ and it's not likely to be imported in too many places; we can just make this a breaking change instead of deprecating the old like we did in the SDK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants