fix: error handling of Serve/ServeTLS funcs #397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skyerus
requested review from
AlexsJones,
james-milligan,
toddbaert and
Kavindu-Dodan
as code owners
skyerus
commented
Feb 9, 2023
james-milligan
approved these changes
Feb 9, 2023
skyerus
force-pushed
the
fix/connect-server-err-handling
branch
from
89738de to
ba47e9f
Compare
beeme1mr
approved these changes
Feb 9, 2023
toddbaert
approved these changes
Feb 9, 2023
Kavindu-Dodan
approved these changes
Feb 9, 2023
Signed-off-by: Skye Gill <[email protected]>
skyerus
force-pushed
the
fix/connect-server-err-handling
branch
from
ba47e9f to
ed0d713
Compare
Kavindu-Dodan
pushed a commit
that referenced
this pull request
Feb 13, 2023
🤖 I have created a release *beep* *boop* --- ## [0.3.7](v0.3.6...v0.3.7) (2023-02-13) ### Bug Fixes * **deps:** update module golang.org/x/net to v0.6.0 ([#396](#396)) ([beb7564](beb7564)) * **deps:** update module google.golang.org/grpc to v1.53.0 ([#388](#388)) ([174cd7c](174cd7c)) * error handling of Serve/ServeTLS funcs ([#397](#397)) ([8923bf2](8923bf2)) * fix race in http sync test ([#401](#401)) ([1d0c8e1](1d0c8e1)) * sbom artefact name ([#380](#380)) ([3daef26](3daef26)), closes [#379](#379) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Fixes error handling of Serve/ServeTLS being deferred until flagd shutdown.
If an error occurred from one of these functions, it'd be ignored until shutdown.
Related Issues
Notes
Follow-up Tasks
How to test