-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support TLS connection in flagd provider #48
Conversation
60a77dc
to
dea30dc
Compare
Let me do a manual test with this (unless you already have) |
I did, but I would really appreciate that. Thank you! I already have a testing mechanism/code that I can share with you, or do you want to do it completely independent ? |
50be719
to
be093aa
Compare
Despite my efforts, I was not able to get this to work, though I can't see anything wrong with your code. I generated a keys/certs like so: openssl ecparam -name prime256v1 -genkey -noout -out ca.key
openssl req -new -x509 -sha256 -key ca.key -out ca.crt
openssl ecparam -name prime256v1 -genkey -noout -out server.key
openssl req -new -sha256 -subj "/C=US/ST=Oregon/L=Portland/O=Company Name/OU=Org/CN=localhost" -key server.key -out server.csr
openssl x509 -req -in server.csr -CA ca.crt -CAkey ca.key -out server.crt -days 1000 -sha256 Then I started flagd like:
When I set the env vars (
I think flagd is configured correctly, because my curl to it works:
|
test/OpenFeature.Contrib.Providers.Flagd.Test/FlagdProviderTest.cs
Outdated
Show resolved
Hide resolved
@odubajDT Please take a look at my PR to your fork. I was able to get the TLS test I had locally working with this. I hope it explains things. |
ffc565c
to
ced7e7e
Compare
Signed-off-by: odubajDT <[email protected]>
ced7e7e
to
dca5d09
Compare
Signed-off-by: odubajDT <[email protected]>
Signed-off-by: odubajDT <[email protected]>
fa5a8c8
to
a383a08
Compare
Signed-off-by: odubajDT <[email protected]> Signed-off-by: Vladimir Petrusevici <[email protected]>
Related Issues
Fixes #36