Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set up commit restriction unless all checks have passed for a pull request #39

Closed
Skarlso opened this issue Aug 2, 2022 · 2 comments
Closed

Set up commit restriction unless all checks have passed for a pull request #39

Skarlso opened this issue Aug 2, 2022 · 2 comments
Labels
kind/feature new feature, enhancement, improvement, extension

Comments

@Skarlso
Copy link
Contributor

Skarlso commented Aug 2, 2022

What would you like to be added:

This PR adds PR checks. We should enforce these checks to be green. Unless they are all green, we shouldn't allow a PR to be merged.

Why is this needed:
@Skarlso Skarlso added the kind/feature new feature, enhancement, improvement, extension label Aug 2, 2022
@yitsushi
Copy link
Contributor

yitsushi commented Sep 7, 2022

Isn't it done already?

@Skarlso
Copy link
Contributor Author

Skarlso commented Sep 7, 2022

Yep, thanks.

@Skarlso Skarlso closed this as completed Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/feature new feature, enhancement, improvement, extension
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Skarlso @yitsushi @gardener-robot