fix: context base resolvers used to resolve components #1205
+112
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
kind/bugfix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Using the ocm config it is possible to configure default resolvers for component versions.
THis is mainly used to implicitly provide lookup repository when following component version references
by recursive operations, like transport and signing.
But they are also used to support the parsing of component version references of the command line.
If configured, the repository part of the component version notation (for example for
ocm get component ....)can be omitted and the given name is searched for by using the given resolvers.
Unfortunately this works only for the specification of component versions. But the command line also allows to specify
component names, only. Typically, then all versions of those components are listed (for the command shown as example).
This is inconsistent, because is doe not for together with resolvers.
This PR introduces the missing case to lookup all versions of a component found via a given component resolver.
Which issue(s) this PR fixes
Fixes #1204