Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace host splitting with net.SplitHostPort to avoid splitting ipv6 formats #1153

Open
Skarlso opened this issue Nov 28, 2024 · 0 comments
Labels
area/cicd Continuous Integration and Continuous Deployment related area/ipcei Important Project of Common European Interest kind/feature new feature, enhancement, improvement, extension

Comments

@Skarlso
Copy link
Contributor

Skarlso commented Nov 28, 2024

What would you like to be added:

Instead of

	host := hostport
	i := strings.Index(hostport, ":")
	if i > 0 {
		host = hostport[:i]
	}

use net.SplitHostPort.

Why is this needed:

IPv6 Support is requiring this.

@Skarlso Skarlso added the kind/feature new feature, enhancement, improvement, extension label Nov 28, 2024
@Skarlso Skarlso added the area/cicd Continuous Integration and Continuous Deployment related label Nov 28, 2024
@github-actions github-actions bot added the area/ipcei Important Project of Common European Interest label Nov 28, 2024
@Skarlso Skarlso moved this from 🆕 ToDo to 📋 Next-UP in OCM Backlog Board Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cicd Continuous Integration and Continuous Deployment related area/ipcei Important Project of Common European Interest kind/feature new feature, enhancement, improvement, extension
Projects
Status: 📋 Next-UP
Development

No branches or pull requests

1 participant