From e8be8e7551cdde2cb835976ad4379e46057f329e Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jakob=20M=C3=B6ller?= <jakob.moeller@sap.com>
Date: Tue, 29 Oct 2024 13:41:24 +0100
Subject: [PATCH] chore: release fallout corrections (#1023)

runs make generate because it was only run on the release branch. adds
check as mandatory dep of release to make sure the tag-check inside is
not rgiacing against release. adds necessary build steps for tools
needed in make generate.

<!-- markdownlint-disable MD041 -->
#### What this PR does / why we need it

#### Which issue(s) this PR fixes
<!--
Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.
-->
---
 .github/workflows/release.yaml | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/.github/workflows/release.yaml b/.github/workflows/release.yaml
index c28e0b05e4..fa9dcc133e 100644
--- a/.github/workflows/release.yaml
+++ b/.github/workflows/release.yaml
@@ -119,9 +119,10 @@ jobs:
       pull-requests: read
 
   release:
-#    needs:
-#     - lint-and-test
-#     - components
+    needs:
+    # run check before actual release to make sure we succeed
+    # they will be skipped from the needs check
+    - check
     name: Release Build
     runs-on: large_runner
     permissions:
@@ -283,7 +284,7 @@ jobs:
         v="$(go run ./api/version/generate bump-version)"
         echo "$v" > VERSION
         # Trigger a bump of any potential files that depend on a new version
-        make generate
+        make -f hack/Makefile mdref && make -f hack/Makefile go-bindata && make generate
         git add --all
         git commit -m "Update version to $v"
         git push origin ${GITHUB_REF#refs/heads/}