Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli plugin follow up #206

Closed
9 tasks
Tracked by #219
fabianburth opened this issue Jun 12, 2024 · 1 comment
Closed
9 tasks
Tracked by #219

cli plugin follow up #206

fabianburth opened this issue Jun 12, 2024 · 1 comment
Assignees
Labels
kind/task small task, normally part of feature or epic

Comments

@fabianburth
Copy link

fabianburth commented Jun 12, 2024

Description

  • CLI Plugins should be able to provide a config. Therefore, we could register configs during installation.
  • Currently, we might open logfiles twice, once in the plugin and once in the library. In this case, they overwrite each other. This should be handled differently.
  • Implement Context.UpdateConfig() or find other possibility to avoid the update at all (especially relevant for cases such as logging, where the configuration is a side effect)
  • Separate errors and logs (in plugins). Therefore, check if it is possible to log to a different file descriptor than stderr.
  • For config types, separate description from format version

Related EPIC

Done Criteria

  • ...
  • Code has been reviewed by other team members
  • Internal technical Documentation created/updated
  • New / changed code is documented
  • Analysis of existing tests (Unit and Integration)
  • Unit Tests created for new code or existing Unit Tests updated
  • Integration Test Suite updated (includes deletion of existing unnecessary Integration Test and/or creation of new ones if required)
  • Enduser Documentation updated (if applicable)
  • Successful demonstration in Review
@fabianburth fabianburth added the kind/task small task, normally part of feature or epic label Jun 12, 2024
@fabianburth fabianburth moved this to 🆕 ToDo in OCM Backlog Board Jun 12, 2024
@fabianburth fabianburth moved this from 🆕 ToDo to 📋 Next-UP in OCM Backlog Board Jun 12, 2024
@fabianburth fabianburth changed the title generic config for plugins cli plugin follow up Jun 12, 2024
@mandelsoft
Copy link

done by open-component-model/ocm#815

@github-project-automation github-project-automation bot moved this from 📋 Next-UP to 🍺 Done in OCM Backlog Board Jun 25, 2024
@ocmbot ocmbot bot moved this from 🍺 Done to 🔒Closed in OCM Backlog Board Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/task small task, normally part of feature or epic
Projects
Status: 🔒Closed
Development

No branches or pull requests

2 participants